From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tassilo Horn Subject: Re: [Accepted] Re: [bug] org-store-link on gnus message fails Date: Thu, 13 Jan 2011 14:38:27 +0100 Message-ID: <87k4i8zzxo.fsf@member.fsf.org> References: <87bp3moyua.fsf@member.fsf.org> <20110113115301.68C0B87448A@ehef110.hef.ru.nl> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from [140.186.70.92] (port=45894 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PdNNn-0007Eq-3j for emacs-orgmode@gnu.org; Thu, 13 Jan 2011 08:38:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PdNNl-0003XB-Ij for emacs-orgmode@gnu.org; Thu, 13 Jan 2011 08:38:30 -0500 Received: from deliver.uni-koblenz.de ([141.26.64.15]:2914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PdNNl-0003X6-E3 for emacs-orgmode@gnu.org; Thu, 13 Jan 2011 08:38:29 -0500 In-Reply-To: <20110113115301.68C0B87448A@ehef110.hef.ru.nl> (Carsten Dominik's message of "Thu, 13 Jan 2011 12:53:01 +0100 (CET)") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Carsten Dominik Cc: emacs-orgmode@gnu.org Carsten Dominik writes: Hi Carsten, > Patch 533 (http://patchwork.newartisans.com/patch/533/) is now "Accepted". The patch below was wrong. The patch in the next mail that used `ignore-errors' instead of `condition-case' is the right one. Bye, Tassilo >> diff --git a/lisp/org-gnus.el b/lisp/org-gnus.el >> index 32641bf..ae5dc52 100644 >> --- a/lisp/org-gnus.el >> +++ b/lisp/org-gnus.el >> @@ -152,11 +152,16 @@ If `org-store-link' was called with a prefix arg the meaning of >> (from (mail-header-from header)) >> (message-id (org-remove-angle-brackets (mail-header-id header))) >> (date (org-trim (mail-header-date header))) >> - (date-ts (and date (format-time-string >> - (org-time-stamp-format t) (date-to-time date)))) >> - (date-ts-ia (and date (format-time-string >> - (org-time-stamp-format t t) >> - (date-to-time date)))) >> + (date-ts (and date >> + (condition-case nil >> + (format-time-string >> + (org-time-stamp-format t) >> + (date-to-time date))))) >> + (date-ts-ia (and date >> + (condition-case nil >> + (format-time-string >> + (org-time-stamp-format t t) >> + (date-to-time date))))) >> (subject (copy-sequence (mail-header-subject header))) >> (to (cdr (assq 'To (mail-header-extra header)))) >> newsgroups x-no-archive desc link) >>