From: Pieter Praet <email@example.com>
To: Bastien <firstname.lastname@example.org>
Cc: Dave Abrahams <email@example.com>,
Nick Dokos <firstname.lastname@example.org>,
Subject: Re: [PATCH] org-crypt: only warn about auto-save-mode when running org-decrypt
Date: Tue, 28 Jun 2011 08:55:46 +0200 [thread overview]
Message-ID: <email@example.com> (raw)
On Mon, 27 Jun 2011 18:31:58 +0200, Bastien <firstname.lastname@example.org> wrote:
> Hi Pieter,
> Thanks for the patch at the end of this thread.
> Pieter Praet <email@example.com> writes:
> > Ideally, we'd have a defcustom `org-crypt-auto-save' with the following options:
> > - 'ask : Ask the user whether or not to decrypt the entry.
> > - 'disable : Disable auto-save-mode for the current buffer before decrypting.
> > - 'ignore : Decrypt the entry regardless.
> > - 'encrypt : Re-encrypt the entries before auto-save kicks in.
> > I've implemented this, but it fails miserably:
> > Since the function `auto-save-mode' doesn't set an buffer-local
> > var to indicate whether or not it's enabled for the current buffer, we
> > can only check for `auto-save-default'.
> I think we should first ask emacs-devel to fix this, then implement your
> clean solution. Would you like to report this problem?
No need. It appears I'm a veritable moron, with apologies to the Emacs folks.
2 lessons I've learned today:
- DON'T test this stuff in a *scratch* buffer (seriously...)
- DO consume sufficient quantities of coffee (IOW, org-encrypt-entries
doesn't encrypt entries unless they're *tagged* to be)
> I'm not confident in disabling auto-save-mode globally by default, this
> would surprise users -- even with a **BiG WaRnInG** message.
No worries, it's buffer-local.
And I've now changed the default to "ask first, shoot in the foot later".
> What do you think?
"I should send my patch" comes to mind :)
Traffic allowing (lots of sweaty tourists on the road),
it should be there in T-10sec.
next prev parent reply other threads:[~2011-06-28 6:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-30 21:34 Documentation suggestion re: buffers containing crypted entries Bill Day
2011-05-02 3:42 ` Darlan Cavalcante Moreira
2011-06-12 20:41 ` Dave Abrahams
2011-06-24 10:04 ` Eric S Fraga
2011-06-24 10:53 ` Bastien
2011-06-24 13:42 ` Eric S Fraga
2011-06-27 16:56 ` Bastien
2011-06-28 13:29 ` Darlan Cavalcante Moreira
2011-06-24 21:03 ` [PATCH] org-crypt: only warn about auto-save-mode when running org-decrypt Pieter Praet
2011-06-24 21:50 ` Nick Dokos
2011-06-26 6:38 ` Pieter Praet
2011-06-26 8:38 ` [PATCH] org-crypt: make org-decrypt disable auto-save-mode (configurable) Pieter Praet
2011-06-27 16:31 ` [PATCH] org-crypt: only warn about auto-save-mode when running org-decrypt Bastien
2011-06-28 6:55 ` Pieter Praet [this message]
2011-06-28 6:57 ` [PATCH] org-crypt: make org-decrypt disable auto-save-mode (configurable) Pieter Praet
2011-06-28 10:04 ` Bastien
2011-06-28 10:05 ` [PATCH] org-crypt: only warn about auto-save-mode when running org-decrypt Bastien
2011-06-24 11:57 ` Documentation suggestion re: buffers containing crypted entries Bernt Hansen
2011-06-27 16:55 ` Bastien
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).