emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Eric Schulte <eric.schulte@gmx.com>
To: Achim Gratz <Stromeko@nexgo.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: functions from cl package called at runtime
Date: Thu, 19 Jan 2012 11:08:27 -0700	[thread overview]
Message-ID: <87k44n4la9.fsf@gmx.com> (raw)
In-Reply-To: 87aa5k25ml.fsf@Rainer.invalid

Thanks for catching this, I've just pushed up a fix.

Is there a convention for which macros from cl-macs are allowable and
which are forbidden?  For example `flet' is used extensively throughout
the Org-mode code base.  Is the convention that macros are allowable
while functions are not?

Also, while intersection below is a function defined in cl-seq, the use
of `intersection' in ob.el refers to a local function and not the cl-seq
function, so it should be fine.

Thanks,

Achim Gratz <Stromeko@nexgo.de> writes:

> The sources in ob.el have picked up several runtime invocations to
> functions from the cl package via two commits from Eric:
>
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file")))
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file")))
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file")))
> fc92b2e2 lisp/ob.el (let ((tempvar (gensym "file"))
> fc92b2e2 lisp/ob.el   (rx (gensym "rx")))
> abf3060e lisp/ob.el (flet ((intersection (as bs)
> abf3060e lisp/ob.el                      (intersection (cdr as) bs)))))
> abf3060e lisp/ob.el   (intersection (case context
>
> These may need to be revised...
>
>
> Regards,
> Achim.

-- 
Eric Schulte
http://cs.unm.edu/~eschulte/

next prev parent reply	other threads:[~2012-01-19 18:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18 19:05 functions from cl package called at runtime Achim Gratz
2012-01-19 18:08 ` Eric Schulte [this message]
2012-01-19 19:22   ` Achim Gratz
2012-01-19 22:04     ` Eric Schulte

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k44n4la9.fsf@gmx.com \
    --to=eric.schulte@gmx.com \
    --cc=Stromeko@nexgo.de \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).