From: Christopher Schmidt <christopher@ch.ristopher.com>
To: emacs-orgmode@gnu.org
Subject: Re: orgstruct-mode with custom headline prefix
Date: Thu, 31 Jan 2013 09:00:13 +0000 (GMT) [thread overview]
Message-ID: <87k3qt3exu@ch.ristopher.com> (raw)
In-Reply-To: <878v79925v.fsf@bzg.ath.cx> (Bastien's message of "Thu, 31 Jan 2013 09:39:40 +0100")
Bastien <bzg@altern.org> writes:
Hi Bastien,
>> Bastien <bzg@altern.org> writes:
>>> Can you give an indication on how it impacts the generation of
>>> agenda? This is a potential blocker.
>>
>> It should not impact agenda generation at all - neither feature nor
>> performance-wise. All non-trivial changes are in parts of the code
>> that directly relate to orgstruct-mode or
>> org-\(forward\|backward\)-heading-same-level. These functions and
>> their internals are not used non-interactively.
>
> org-outline-regexp-bol, org-\(forward\|backward\)-heading-same-level
> are fundamental vars/functions -- any change here is likely to impact
> the agenda generation. So while I hope you're right, I'd feel better
> with figures and tests :)
org-outline-regexp-bol value is ^org-outline-regexp. There is one place
in org where org-outline-regexp-bol is actually set -
org-with-limited-levels. It is let-bound to (concat "^"
org-outline-regexp).
BTW what is the reason for having both org-outline-regexp and
org-outline-regexp-bol? Matching the latter should be
faster than the former.
org-\(forward\|backward\)-heading-same-level are referenced
non-interactively in three functions - org-forward-element,
org-backward-element and org-copy-subtree. I checked the implementation
of these functions and I did not see how the new behaviour should break
these functions.
After all, the functions now do what they are supposed to do. Try this:
* Org
** Achim
** Bastien
** Carsten
* Diary
Place point on Achim and C-c C-b. Place point on Casten and C-c C-f.
All my agendas generate just fine. I am not exactly sure how I can
provide figures and tests. We do not have any agenda test cases in the
first place.
Please take a look at the patch when you have time. The diff is not
that scary.
Greetings,
Christopher
next prev parent reply other threads:[~2013-01-31 9:00 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-28 17:15 orgstruct-mode with custom headline prefix Christopher Schmidt
2013-01-28 23:22 ` Samuel Wales
2013-01-31 7:35 ` Christopher Schmidt
2013-01-31 7:45 ` Bastien
2013-01-31 8:21 ` Christopher Schmidt
2013-01-31 8:39 ` Bastien
2013-01-31 9:00 ` Christopher Schmidt [this message]
2013-01-31 11:20 ` Bastien
2013-01-31 20:06 ` Christopher Schmidt
2013-01-31 20:12 ` Christopher Schmidt
2013-01-31 20:24 ` Thorsten Jolitz
2013-02-01 16:20 ` Carsten Dominik
2013-02-10 19:11 ` Christopher Schmidt
2013-02-11 15:28 ` Bastien
2013-02-12 19:04 ` Achim Gratz
2013-02-12 20:47 ` Christopher Schmidt
2013-02-12 21:32 ` Bastien
2013-02-13 9:10 ` Christopher Schmidt
2013-02-13 9:43 ` Sebastien Vauban
2013-02-13 20:03 ` Achim Gratz
2013-02-19 10:18 ` Dr Stephen J Eglen
2013-02-22 13:51 ` Bastien
2013-02-26 14:59 ` Stephen Eglen
2013-02-26 16:02 ` Bastien
2013-02-26 18:10 ` Stephen Eglen
2013-02-26 16:55 ` Christopher Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3qt3exu@ch.ristopher.com \
--to=christopher@ch.ristopher.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).