From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Schulte Subject: Re: [PATCH 04/10] Add 'light argument to some uses of org-babel-get-src-block-info Date: Sat, 20 Apr 2013 04:09:08 -0600 Message-ID: <87k3nw7px1.fsf@gmail.com> References: <1364794944-13826-1-git-send-email-aaronecay@gmail.com> <1364794944-13826-5-git-send-email-aaronecay@gmail.com> <8738v7y79j.fsf@gmail.com> <87fvyos4c3.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:51339) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTh26-0003MC-Dx for emacs-orgmode@gnu.org; Sat, 20 Apr 2013 19:17:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UTh25-0005RF-Fd for emacs-orgmode@gnu.org; Sat, 20 Apr 2013 19:17:26 -0400 Received: from mail-pa0-f47.google.com ([209.85.220.47]:38230) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UTh25-0005RA-9N for emacs-orgmode@gnu.org; Sat, 20 Apr 2013 19:17:25 -0400 Received: by mail-pa0-f47.google.com with SMTP id bj1so967323pad.20 for ; Sat, 20 Apr 2013 16:17:24 -0700 (PDT) List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Aaron Ecay writes: > Hi Eric, > > 2013ko apirilak 3an, Eric Schulte-ek idatzi zuen: >> >> Aaron Ecay writes: >> >>> * lisp/ob-core.el (org-babel-do-key-sequence-in-edit-buffer), >>> (org-babel-expand-noweb-references), >>> * lisp/ob-tangle.el (org-babel-tangle): >>> Use 'light argument to `org-babel-get-src-block-info'. >> >> I'd like to apply this patch, however tracing the effects of these >> changes can be tricky and `org-babel-expand-noweb-references' and >> `org-babel-tangle' are both core functions. >> >> Have you run the test suite to confirm that these changes don't break >> any existing tests? > > The test suite gives no failures with this patch. Then please go ahead and apply this patch (or re-send it to me and I can apply it). Cheers, -- Eric Schulte http://cs.unm.edu/~eschulte