From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dokos Subject: Re: org-map-entries moves point Date: Wed, 05 Feb 2014 18:00:27 -0500 Message-ID: <87k3d92mic.fsf@gmail.com> References: <52F295B1.6090806@miszellen.de> <87mwi5uvh2.fsf@alphaville.bos.redhat.com> <52F2B6F1.6040102@miszellen.de> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:54226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBBSb-0005R6-Ga for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 18:00:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WBBSW-0005l0-01 for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 18:00:49 -0500 Received: from plane.gmane.org ([80.91.229.3]:40100) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBBSV-0005kw-Ps for emacs-orgmode@gnu.org; Wed, 05 Feb 2014 18:00:43 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WBBSO-0007nX-RT for emacs-orgmode@gnu.org; Thu, 06 Feb 2014 00:00:36 +0100 Received: from pool-98-110-175-184.bstnma.fios.verizon.net ([98.110.175.184]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 06 Feb 2014 00:00:36 +0100 Received: from ndokos by pool-98-110-175-184.bstnma.fios.verizon.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 06 Feb 2014 00:00:36 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Florian Beck writes: > On 05.02.2014 21:59, Nick Dokos wrote: > >> John Kitchin reported this last week and Bastien reverted that commit: >> >> http://thread.gmane.org/gmane.emacs.orgmode/81587 > > Missed that. But this reverts commit > 3ec38f5c064c3270f54876ba33c5ca1097b46853 [1] (in org-map-entries) > > I was talking about > fe3379bda6ca23474639b114592958bf14431c88 [2] (which did the same to > org-agenda-prepare-buffer) > > In fact, the revert *caused* my bug. Again, the recipe: > > The bug doesn't really move the point, rather it recenters the current > line. To see it, move into the middle of a document, unfold a second > level headline and in the middle of the window execute > > (org-map-entries (lambda () > ;; do something or even nothing > ) nil 'tree) > > This works correctly if either commit [1] is restored or [2] is reverted. > > Does all of [2] have to be reverted? Or can save-window-excursion be changed back to save-excursion? AFAICT, the rest of the fix is independent of that. -- Nick