emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Bastien <bzg@gnu.org>
To: Albert Krewinkel <tarleb@moltkeplatz.de>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org.el (org-offer-links-in-entry): Remove code duplication
Date: Tue, 06 May 2014 11:29:26 +0200	[thread overview]
Message-ID: <87k39zmcw2.fsf@bzg.ath.cx> (raw)
In-Reply-To: <1398350168-18902-1-git-send-email-tarleb@moltkeplatz.de> (Albert	Krewinkel's message of "Thu, 24 Apr 2014 16:36:08 +0200")

Hi Albert,

thanks for the patch.

Albert Krewinkel <tarleb@moltkeplatz.de> writes:

> * org.el (org-offer-links-in-entry): Use `org-any-link-re' to avoid
>   code duplication.

This is not really code duplication, as the output of `org-any-link-re'
is different from the output of the current sexp in the code.

That said, the change looks good anyway.  Can you double-check there
cannot be any problem with the value of `org-any-link-re'?

> The `re' variable defined in function `org-offer-links-in-entry' is
> string-equal to `org-any-link-re' and is hence replaced by the latter.
> This is a TINYCHANGE.

(TINYCHANGE should stand alone on the line.)



  reply	other threads:[~2014-05-06 10:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-24 14:36 [PATCH] org.el (org-offer-links-in-entry): Remove code duplication Albert Krewinkel
2014-05-06  9:29 ` Bastien [this message]
2014-05-11 16:33   ` Albert Krewinkel
2014-05-11 16:33     ` [PATCH] org.el (org-offer-links-in-entry): Reuse global variable Albert Krewinkel
2014-05-20 21:08       ` Bastien
2014-05-11 19:09     ` [PATCH] org.el (org-offer-links-in-entry): Remove code duplication Achim Gratz
2014-05-15 10:41       ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k39zmcw2.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=tarleb@moltkeplatz.de \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox


This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).