From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [RFC] [PATCH] Warn about unexpanded macros on export
Date: Tue, 17 Mar 2015 23:38:09 +0100
Message-ID: <87k2yf1c8e.fsf@nicolasgoaziou.fr>
References: <87k34zqv9r.fsf@gmail.com> <87bnqbv27b.fsf@nicolasgoaziou.fr>
	<87fvfjow6p.fsf@gmail.com> <8738bi13te.fsf@gmx.us>
	<87zjdkl7h0.fsf@gmail.com> <87zjdkw7jt.fsf@nicolasgoaziou.fr>
	<CAA6UvuEPDwjCOG9o1MYxsqk6eUN3muYBqeLRj670FKQ2iAPK8A@mail.gmail.com>
	<8761a23b0i.fsf@nicolasgoaziou.fr>
	<CAA6UvuEqH+FtBBhGe+a_pSK-qSVce4=cEkjqjz1oQdDnALvuXw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46765)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YY06g-00075e-MJ
	for emacs-orgmode@gnu.org; Tue, 17 Mar 2015 18:37:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YY06b-0001nM-JO
	for emacs-orgmode@gnu.org; Tue, 17 Mar 2015 18:37:02 -0400
Received: from relay3-d.mail.gandi.net ([2001:4b98:c:538::195]:39188)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1YY06b-0001n3-Db
	for emacs-orgmode@gnu.org; Tue, 17 Mar 2015 18:36:57 -0400
In-Reply-To: <CAA6UvuEqH+FtBBhGe+a_pSK-qSVce4=cEkjqjz1oQdDnALvuXw@mail.gmail.com>
	(Jacob Gerlach's message of "Tue, 17 Mar 2015 12:20:28 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Jacob Gerlach <jacobgerlach@gmail.com>
Cc: Org-mode <emacs-orgmode@gnu.org>

Jacob Gerlach <jacobgerlach@gmail.com> writes:

> I tried this, or more specifically:
> (or ((org-element-map
> ...
>     info 'first-match))
>   (user-error ...
>  and got a failure on test-org-export/resolve-coderef. It's not
> obvious to me from reading the tests if there is a test that needs to
> be changed, or if it's a legitimate failure and a different approach
> is needed (or if I made a mistake). I asked in [1] for some guidance
> on tests, and I'm still lost.

There is a spurious (...) in the code above.

I implemented it in a886b234763f288670103d2c98169164dedec06c.

>> According to its docstring, `org-id-find-id-file' returns nil when
>> search failed. Isn't it the case?
> Are you looking at `org-id-find-id-in-file' rather than
> `org-id-find-id-file'? The docstring for `org-id-find-file' only says:
> "Query the id database for the file in which this ID is located."

You're right.

>> `org-export-resolve-id-link' could throw an error, indeed.
> I'm not clear on the way forward for id links. I propose removing the
> fall back behavior in `org-id-find-id-file'. If that's acceptable, I
> can provide a patch for `org-export-resolve-id-link'.

Actually, we don't even need to do that. I changed "ox.el" so it uses
`org-id-find' instead of `org-id-find-id-file'. The former has a better
fall-back value. See

  e0b19dedb99d3c01199a159a2da8f9aa4adb2f6f

> Updated fuzzy link patch attached.

Applied (with minor tweaks). Thank you.


Regards,