From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Joost Helberg <joost@snow.nl>
Cc: emacs-orgmode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] ox-html.el ox.el: added list of figures support in html backend
Date: Thu, 12 Nov 2015 23:46:23 +0100 [thread overview]
Message-ID: <87k2pmu98g.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87611btppi.fsf@snow.nl> (Joost Helberg's message of "Mon, 09 Nov 2015 11:46:49 +0100")
Hello,
Joost Helberg <joost@snow.nl> writes:
> this patch adds the list of figures to the html export backend. It also
> includes a translation entry-point for the label "List of Figures" with
> already one translation in: dutch.
Thank you.
> From fab9105d04e5cb9f923c17d322d84a25527ec27a Mon Sep 17 00:00:00 2001
> From: Joost Helberg <joost@snow.nl>
> Date: Sun, 8 Nov 2015 14:34:11 +0100
> Subject: [PATCH] ox-html.el: added list of figures support in html
> backend
It should be
ox-html: Add list of figures
> * lisp/ox-html.el (org-html-list-of-figures): new, similar to
> org-html-list-of-tables but with tables replaced by figures.
This is, indeed, almost the same as `org-html-list-of-tables' and
`org-html-list-of-listings'. I suggest to refactor the 3 functions to
use a generic one.
Also please use a recent version of `org-html-list-of-tables' since
yours contain deprecated code (e.g., `org-export-solidify-link-text').
> (org-html-list-of-tables): added mapping keyword "figures"
> to new function org-html-list-of-figures.
You can remove this.
> ox.el: added label for "list of figures"
Ditto.
> * lisp/ox.el (org-export-dictionary): Added label for List of
> Figures with dutch translation
You need to add TINYCHANGE at the end of the commit message, if you
haven't signed FSF papers yet.
> +(defun org-html-list-of-figures (info)
> + "Build a list of figures.
> +INFO is a plist used as a communication channel. Return the list
> +of figures as a string, or nil if it is empty."
> + (let ((lol-entries (org-export-collect-figures info nil)))
(org-export-collect-figures info nil)
is rather sloppy. It collects all paragraphs with a caption. Is it
a proper definition for "figures"?
Regards,
--
Nicolas Goaziou
prev parent reply other threads:[~2015-11-12 22:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 10:46 [PATCH] ox-html.el ox.el: added list of figures support in html backend Joost Helberg
2015-11-12 22:46 ` Nicolas Goaziou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2pmu98g.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=joost@snow.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).