emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Jakob Lombacher <Jakob@lombacher.net>
Cc: Adam Porter <adam@alphapapa.net>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] custom port for postgresql
Date: Sat, 17 Sep 2016 10:39:34 +0200	[thread overview]
Message-ID: <87k2earkc9.fsf@saiph.selenimh> (raw)
In-Reply-To: <CALAc-BsHsGo6cRhnSX7B_L=Mxq7kj9Hr=iVZPspxYJTL6nruoA@mail.gmail.com> (Jakob Lombacher's message of "Fri, 16 Sep 2016 09:48:45 +0200")

Hello,

Jakob Lombacher <Jakob@lombacher.net> writes:

> I changed the dbport as optional argument and added the dbpassword option
> as well.

I applied your patch with the modifications below:

- I added a proper commit message

- I added TINYCHANGE cookie

- I reordered dbport argument as in your initial patch. Although the
  recommendation of making it optional makes sense, it breaks
  consistency with other "dbstring" functions, and this is an internal
  function anyway.

Could you provide an entry for ORG-NEWS file?

Thank you for the patch.

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2016-09-17  8:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-16  7:48 [PATCH] custom port for postgresql Jakob Lombacher
2016-09-17  8:39 ` Nicolas Goaziou [this message]
2016-09-22 14:03   ` Jakob Lombacher
2016-09-22 19:50     ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2earkc9.fsf@saiph.selenimh \
    --to=mail@nicolasgoaziou.fr \
    --cc=Jakob@lombacher.net \
    --cc=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).