From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Goaziou Subject: Re: [Patch] Support for dimming local to each agenda Date: Fri, 14 Jul 2017 14:18:01 +0200 Message-ID: <87k23bciva.fsf@nicolasgoaziou.fr> References: <8760ewfqja.fsf@nicolasgoaziou.fr> <87k23be81f.fsf@nicolasgoaziou.fr> <87pod3cq6w.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:47588) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dVzXq-0006WS-Ab for emacs-orgmode@gnu.org; Fri, 14 Jul 2017 08:18:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dVzXp-0005dv-Cm for emacs-orgmode@gnu.org; Fri, 14 Jul 2017 08:18:06 -0400 Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:46259) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dVzXp-0005dR-6A for emacs-orgmode@gnu.org; Fri, 14 Jul 2017 08:18:05 -0400 In-Reply-To: <87pod3cq6w.fsf@nicolasgoaziou.fr> (Nicolas Goaziou's message of "Fri, 14 Jul 2017 11:39:51 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: Yuri Lensky Cc: "emacs-orgmode@gnu.org" Nicolas Goaziou writes: > Yuri Lensky writes: > >> Why not save mark? > > We usually do not mess with it, unless this is explicit in the function > documentation, e.g., `org-mark-ring-push'. > >> This allows user-defined hooks in org-blocker-hooks more freedom. > > I'm not sure this is a sufficient reason, really. Besides it's > debatable. > >> That said, I am not sure of org-mode project conventions, so if >> `save-excursion' is preferred I can change it to that. > > I'm going to do the change myself and apply you patch. No need for > another iteration. Done. Would you mind providing an ORG-NEWS entry? Thank you!