From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: TIMEZONE property for ical export
Date: Sat, 19 Aug 2017 21:25:10 +0200
Message-ID: <87k21zjr6x.fsf@nicolasgoaziou.fr>
References: <87ziawx1f7.fsf@ericabrahamsen.net>
	<87fucolzv5.fsf@nicolasgoaziou.fr> <87a82vv5up.fsf@ericabrahamsen.net>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57296)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dj9Mx-00076w-PA
	for emacs-orgmode@gnu.org; Sat, 19 Aug 2017 15:25:16 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dj9Mw-00047J-Qa
	for emacs-orgmode@gnu.org; Sat, 19 Aug 2017 15:25:15 -0400
Received: from relay2-d.mail.gandi.net ([2001:4b98:c:538::194]:60248)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dj9Mw-000472-Ke
	for emacs-orgmode@gnu.org; Sat, 19 Aug 2017 15:25:14 -0400
In-Reply-To: <87a82vv5up.fsf@ericabrahamsen.net> (Eric Abrahamsen's message of
	"Sat, 19 Aug 2017 10:13:02 -0700")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Eric Abrahamsen <eric@ericabrahamsen.net>
Cc: emacs-orgmode@gnu.org

Eric Abrahamsen <eric@ericabrahamsen.net> writes:

>> BTW, as long as Org doesn't support time zones, the "ox-icalendar"
>> property may be prefixed with "ICALENDAR_" (e.g., ICALENDAR_TZ).
>
> Done!

I realize this is not a great idea since other properties do not have
"ICALENDAR_" prefix. Sorry about that. I suggest to go back to TIMEZONE.

> How does the attached patch look?

> -	     (cat (org-icalendar-get-categories entry info)))
> +	     (cat (org-icalendar-get-categories entry info))
> +	     (tz (org-element-property :ICALENDAR_TZ entry)))

Note that "ICALENDAR_TZ" is not inherited in this case. Neither are
LOCATION and so on, tho. You would need to use
`org-export-get-node-property' in conjunction with
`org-property-inherit-p'.

> -event belongs to.
> +event belongs to. TIMEZONE specifies a time zone for this event
> +only.

Missing space.

Could you add a commit message and an ORG-NEWS entry?

Regards,