emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Adam Porter <adam@alphapapa.net>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] org-agenda: Add 'none setting for org-agenda-overriding-header
Date: Sun, 10 Sep 2017 14:32:41 +0200	[thread overview]
Message-ID: <87k216zqc6.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87tw0fcu0j.fsf@alphapapa.net> (Adam Porter's message of "Wed, 06 Sep 2017 18:00:28 -0500")

Hello,

Adam Porter <adam@alphapapa.net> writes:

> I looked at that file and I see that it's pretty basic.

There's a first step in everything.

> I recently put together a sort of testing framework for
> org-super-agenda that makes it pretty easy to develop and run
> consistent tests on agendas:
>
> https://github.com/alphapapa/org-super-agenda/blob/master/test/test.el
>
> Would you be interested in a patch that adds something like that to Org?
> It would make it easy to test specific agenda features, and I guess it
> might help with your agenda rewrite.  :)

Thank you.

I didn't try it, but AFAIU, it requires to learn some DSL to write
tests. There are two possible issues: 
- the DSL does not cover all use cases, and therefore gets in the way;
- the DSL implies overhead in writing tests, which is counterproductive.

I didn't test your library, so I cannot tell if your system suffers from
one of the items above. I'm merely pointing out my concerns.

OTOH, I think we need proper tooling to write tests for Org agenda.
Since you put some thought in it, do you think it is feasible to have
something like this, albeit more lightweight (e.g., macros around
regular Org code instead of a DSL)? If so, would you to give it a try?

Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2017-09-10 12:32 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16  4:20 [PATCH] org-agenda: Add 'none setting for org-agenda-overriding-header Adam Porter
2017-08-17 14:25 ` Nicolas Goaziou
2017-08-17 19:57   ` Adam Porter
2017-08-18  9:07     ` Nicolas Goaziou
2017-08-20  2:47       ` Adam Porter
2017-08-20  8:25         ` Nicolas Goaziou
2017-08-23  1:41           ` Adam Porter
2017-08-23  2:32             ` Adam Porter
2017-08-23  8:48               ` Nicolas Goaziou
2017-09-02  2:41                 ` Adam Porter
2017-09-02  7:49                   ` Nicolas Goaziou
2017-09-03  1:44                     ` Adam Porter
2017-09-06 11:17                       ` Nicolas Goaziou
2017-09-06 23:00                         ` Adam Porter
2017-09-10 12:32                           ` Nicolas Goaziou [this message]
2017-09-06 23:06                         ` Adam Porter
2017-08-23  8:37             ` Nicolas Goaziou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k216zqc6.fsf@nicolasgoaziou.fr \
    --to=mail@nicolasgoaziou.fr \
    --cc=adam@alphapapa.net \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).