From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: org-notmuch: Improved tree support
Date: Wed, 03 Apr 2019 12:56:15 +0200
Message-ID: <87k1gbichc.fsf@nicolasgoaziou.fr>
References: <87h8bzb2jy.fsf@bababa.i-did-not-set--mail-host-address--so-tickle-me>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:45536)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1hBdZB-0001MQ-CO
	for emacs-orgmode@gnu.org; Wed, 03 Apr 2019 06:56:26 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1hBdZA-0000vZ-8v
	for emacs-orgmode@gnu.org; Wed, 03 Apr 2019 06:56:25 -0400
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:51017)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1hBdZ9-0000pD-QI
	for emacs-orgmode@gnu.org; Wed, 03 Apr 2019 06:56:24 -0400
In-Reply-To: <87h8bzb2jy.fsf@bababa.i-did-not-set--mail-host-address--so-tickle-me>
	(Pierre Neidhardt's message of "Tue, 19 Mar 2019 11:07:13 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Pierre Neidhardt <mail@ambrevar.xyz>
Cc: emacs-orgmode@gnu.org

Hello,

Pierre Neidhardt <mail@ambrevar.xyz> writes:

> 1. `org-notmuch-store-link' does not allow to store links to email at
> point in tree view.  Easy fix:
>
> --8<---------------cut here---------------start------------->8---
> (defun org-notmuch-store-link ()
>   "Store a link to a notmuch search or message."
> -  (when (eq major-mode 'notmuch-show-mode)
> +  (when (or (eq major-mode 'notmuch-show-mode)
> +            (eq major-mode 'notmuch-tree-mode))
>     (let* ((message-id (notmuch-show-get-message-id t))
> --8<---------------cut here---------------end--------------->8---

Applied. Thank you.

> 2. A while back
> https://lists.gnu.org/archive/html/emacs-orgmode/2014-07/msg00380.html
> was merged.  I think using a defcustom here is not very intuitive for
> people who use both the tree view and the thread view.  I would expect
> the following:
>
> - Opening a tree link will open the tree view.
> - Opening a search link will open the search view.
>
> It's easy to implement:
>
> - Deprecate the former defcustom.
> - Copy/paste the org-notmuch-search* code to org-notmuch-tree*.

I do not use ol-notmuch (new name in master for org-notmuch), but it
sounds reasonable.

Do you want to take care of it?

Regards,

-- 
Nicolas Goaziou