From mboxrd@z Thu Jan 1 00:00:00 1970 From: stardiviner Subject: Re: [PATCH] Re: ob-clojure.el: Add ClojureScript interface Date: Fri, 14 Feb 2020 13:24:14 +0800 Message-ID: <87k14prbb5.fsf@gmail.com> References: <20180422205003.87836-1-roberthambrock@gmail.com> <20180422205003.87836-3-roberthambrock@gmail.com> <87v9ocuesg.fsf@gmail.com> <87imkb7mwj.fsf@gnu.org> <87y2t6fqwj.fsf@gmail.com> <87pnei8oe0.fsf@bzg.fr> Reply-To: numbchild@gmail.com Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:54484) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j2TSh-0007GI-TW for emacs-orgmode@gnu.org; Fri, 14 Feb 2020 00:24:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j2TSg-00031z-Nm for emacs-orgmode@gnu.org; Fri, 14 Feb 2020 00:24:23 -0500 In-reply-to: <87pnei8oe0.fsf@bzg.fr> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane-mx.org@gnu.org Sender: "Emacs-orgmode" To: Bastien Cc: roberthambrock@gmail.com, emacs-orgmode@gnu.org =2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 About this patch, last night, I try to test ob-clojurescript eval with CIDER connection. But no luck, the ClojureScript REPL connection always failed to start. I have problem on CIDER. So I have a request that can you take a tes= t. Because on my side, ~(cider-current-connection "cljs")~ returns ~nil~ unabl= e to test. I think this patch should work. Just for confirm. Thanks in advance. Bastien writes: > Hi, > > stardiviner writes: > >> And patches in attachments. > > Applied, thanks. > > I made some minor modifications: > > - I added the TINYCHANGE cookie in both messages > - I replaced "ob-clojure.el: (...)" by "ob-clojure.el (...):" > > In general, try `C-x 4 a' on a change, either from magit or from > the modified buffer: this will format a correct changelog entry. > > Also, users may need to figure out that ClojureScript src blocks > need a proper environment to execute src blocks. I.e. we should > recommend users to have their .org file within a ClojureScript > project -- I added something along these lines in the ORG-NEWS > entry. > > If you want to contribute further, you'd need to sign the FSF > papers: https://orgmode.org/request-assign-future.txt > > Thanks! =2D --=20 [ stardiviner ] I try to make every word tell the meaning what I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 =20=20=20=20=20=20 =2D----BEGIN PGP SIGNATURE----- iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl5GLv4UHG51bWJjaGls ZEBnbWFpbC5jb20ACgkQG13xyVromsMkfAf/fFCfp91u8ZtK9VyVjlpf+tZ0wZzU 7d0OPcbnEtUZH/FkGyG2eFgXN/WBnf8O31ESj5EyXtnDGNZSa3Ia/cgmC7ZtCJRp 9w7YbwPnfM9EBq5qK7R+9i6fCEcua5i4Oszx4x1erWuksfGogCdKN6gwZJMYlH5y lqdGQ0LCZMnTxDHn4mi8JuM2K0kaaIK4oJMJmCLu8+/X6lvTbLjGsTl08dew0Pbx jMEkV/3FvtFNeS7MZIIrZedPgAhiS3o6IUj+hmngVpKdcabOZmBkV5IFgvMB77Us SuSKs3Y9Y4hlWZyBMV2Twc4lKicnO31vGJm9MmFn4LCjI3Fd5O6LFEnL0A=3D=3D =3DGDMy =2D----END PGP SIGNATURE-----