From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id nGacHGdP1F7SMwAA0tVLHw (envelope-from ) for ; Mon, 01 Jun 2020 00:44:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id GO8DGGdP1F6tYgAAbx9fmQ (envelope-from ) for ; Mon, 01 Jun 2020 00:44:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 07EA6940145 for ; Mon, 1 Jun 2020 00:44:23 +0000 (UTC) Received: from localhost ([::1]:52496 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfYYv-0004gK-Ml for larch@yhetil.org; Sun, 31 May 2020 20:44:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43706) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jfYYb-0004g0-Hf for emacs-orgmode@gnu.org; Sun, 31 May 2020 20:44:01 -0400 Received: from [183.249.132.153] (port=1194 helo=localhost) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jfYYa-0000KR-JK for emacs-orgmode@gnu.org; Sun, 31 May 2020 20:44:01 -0400 Received: by localhost (Postfix, from userid 1000) id D0D362414E0; Mon, 1 Jun 2020 08:43:53 +0800 (CST) References: <874kryi3g6.fsf@gmail.com> <87mu5oby49.fsf@gmail.com> <87o8q4t5k4.fsf@fastmail.fm> User-agent: mu4e 1.4; emacs 28.0.50 From: stardiviner To: Matthew Lundin Subject: Re: [PATCH v2] Re: [BUG] recently commits on master branch breaks command 'org-babel-demarcate-block' In-reply-to: <87o8q4t5k4.fsf@fastmail.fm> Date: Mon, 01 Jun 2020 08:43:53 +0800 Message-ID: <87k10r1upi.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Host-Lookup-Failed: Reverse DNS lookup failed for 183.249.132.153 (deferred) Received-SPF: softfail client-ip=183.249.132.153; envelope-from=numbchild@gmail.com; helo=localhost X-detected-operating-system: by eggs.gnu.org: First seen = 2020/05/31 20:43:54 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: 53 X-Spam_score: 5.3 X-Spam_bar: +++++ X-Spam_report: (5.3 / 5.0 requ) BAYES_00=-1.9, DKIM_ADSP_CUSTOM_MED=0.001, FORGED_GMAIL_RCVD=1, FREEMAIL_FROM=0.001, FSL_HELO_NON_FQDN_1=0.001, HELO_LOCALHOST=3.828, NML_ADSP_CUSTOM_MED=0.9, RDNS_NONE=0.793, SPF_SOFTFAIL=0.665, URIBL_BLOCKED=0.001 autolearn=_AUTOLEARN X-Spam_action: reject X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: numbchild@gmail.com Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 1.59 X-TUID: CkZpiiOvP4Hm =2D----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Matthew Lundin writes: > stardiviner writes: > >> I updated the patch commit message. >> >> From b0bdf52a305cb5f9663ee1dc2d08c5de6c7cb602 Mon Sep 17 00:00:00 2001 >> From: stardiviner >> Date: Sun, 31 May 2020 10:59:41 +0800 >> Subject: [PATCH] fix 5f0a9cca3 missing space >> >> * lisp/ob-core.el (org-babel-demarcate-block): replace wrong newline >> with missing space. >> --- >> lisp/ob-core.el | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/lisp/ob-core.el b/lisp/ob-core.el >> index e554e3934..79937e517 100644 >> --- a/lisp/ob-core.el >> +++ b/lisp/ob-core.el >> @@ -1908,7 +1908,7 @@ (defun org-babel-demarcate-block (&optional arg) >> (if (looking-at "^") "" "\n") >> indent (if upper-case-p "#+END_SRC\n" "#+end_src\n") >> (if arg stars indent) "\n" >> - indent (if upper-case-p "#+BEGIN_SRC\n" "#+begin_src\n") >> + indent (if upper-case-p "#+BEGIN_SRC\n" "#+begin_src ") >> lang >> (if (> (length headers) 1) >> (concat " " headers) headers) >> --=20 >> 2.26.2 >> > > I think you also need to replace the newline with a space in the upper > case version. > Supposed there is \n after #+end_src. I also checked the original version b= efore that change commit. The original has an newline. I write patch by comparing before and after (side by side). =2D --=20 [ stardiviner ] I try to make every word tell the meaning that I want to express. Blog: https://stardiviner.github.io/ IRC(freenode): stardiviner, Matrix: stardiviner GPG: F09F650D7D674819892591401B5DF1C95AE89AC3 =2D----BEGIN PGP SIGNATURE----- iQFIBAEBCAAyFiEE8J9lDX1nSBmJJZFAG13xyVromsMFAl7UT0kUHG51bWJjaGls ZEBnbWFpbC5jb20ACgkQG13xyVromsOt0ggAtPk/dBaarsrRZOLJaN3SUtMeeIUM BVdY5194hxKVYSxGtvAZDEi4MimfUgBzuXfaytYlVDeBxd1ShBbaoRNecqzlvaLm qUAvI3S1ALJKfE4NKZrGwmZAbYdSE1OlJrhNz5IZ5xuJRWIz/ssJyVNhXbwwXy5o QIbKxdzFdQ1g1iEYJOJS6U7yv2glmLkjgqmosMmFoJCA9Qrup898drdeOqwtUM9n dmy5uehZonZ0bQpyr6Y09jrWj9fsDD53noZH2K1J2LeHYtf5TMrL+mxMRBSuK8SP BgfwPqz9mYh1/YQzgYfB0s+J/zT1oBzD08WHHmqxbtM0sOc4ixkv7xszIg=3D=3D =3Dr+5b =2D----END PGP SIGNATURE-----