From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aN3/KAd/J18bbgAA0tVLHw (envelope-from ) for ; Mon, 03 Aug 2020 03:05:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eLnlJAd/J18yfwAAB5/wlQ (envelope-from ) for ; Mon, 03 Aug 2020 03:05:43 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 33FCC94062E for ; Mon, 3 Aug 2020 03:05:43 +0000 (UTC) Received: from localhost ([::1]:33930 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k2QnG-00052n-5r for larch@yhetil.org; Sun, 02 Aug 2020 23:05:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44406) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2Qmt-00052f-Ce for emacs-orgmode@gnu.org; Sun, 02 Aug 2020 23:05:19 -0400 Received: from pb-smtp21.pobox.com ([173.228.157.53]:60225) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k2Qmr-00027G-IR for emacs-orgmode@gnu.org; Sun, 02 Aug 2020 23:05:19 -0400 Received: from pb-smtp21.pobox.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 1A499ED3D3; Sun, 2 Aug 2020 23:05:16 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:in-reply-to:references:date:message-id:mime-version :content-type; s=sasl; bh=qoU3RyIR7Ov5uWC9lddrkrc6kPI=; b=LfonS1 jyA+6aEBXA1tCxgkLKSd6c5Vkev1NeA2J0wcDz/H6jeJrTF14adFKnxiv6Tf37LR 8hEQUJjRZChnJBoM1e4mG7WgvyyCDGiZ5dLCAvYHKAQxNl8nH/5989qiprWYbz6w n02TveBTk914AMmFVid6O14CRARrwL2nU/s/I= Received: from pb-smtp21.sea.icgroup.com (unknown [127.0.0.1]) by pb-smtp21.pobox.com (Postfix) with ESMTP id 12F7EED3D2; Sun, 2 Aug 2020 23:05:16 -0400 (EDT) (envelope-from kyle@kyleam.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:in-reply-to:references:date:message-id:mime-version:content-type; s=mesmtp; bh=sTfzZW9q+1Afm/vWLnZ2UWRmk2M3gxFDGEHYpEkxHe8=; b=XrEsWF0WqC1FhIbkJ3Ei/i7UJi+MotelI7YOOnkBUztSEKM1qh7JHV/jAEWIKqJeifal9dF0xpfanii2/K8H/l/q+dzn0PMWTSUcaPWZE55uroY99Hq6xmKcikhf4wiOE7n0mMSa9wjTlW/7m9AD+hbRqazcsV13HOskm/FJjfY= Received: from localhost (unknown [45.33.91.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by pb-smtp21.pobox.com (Postfix) with ESMTPSA id 6FDA0ED3D1; Sun, 2 Aug 2020 23:05:13 -0400 (EDT) (envelope-from kyle@kyleam.com) From: Kyle Meyer To: Tom Gillespie Subject: Re: [PATCH] lisp/ob-core.el: pass expanded body to org-confirm-babel-evaluate In-Reply-To: References: <87k0ywyydv.fsf@kyleam.com> Date: Sun, 02 Aug 2020 23:05:11 -0400 Message-ID: <87k0yg4efs.fsf@kyleam.com> MIME-Version: 1.0 Content-Type: text/plain X-Pobox-Relay-ID: 263D1E7C-D536-11EA-B7D9-843F439F7C89-24757444!pb-smtp21.pobox.com Received-SPF: pass client-ip=173.228.157.53; envelope-from=kyle@kyleam.com; helo=pb-smtp21.pobox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/08/02 23:05:16 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=pobox.com header.s=sasl header.b=LfonS1 j; dkim=pass header.d=kyleam.com header.s=mesmtp header.b=XrEsWF0W; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Spam-Score: 0.29 X-TUID: htAL9FwL/FFU Tom Gillespie writes: > Sorry for the slow turnaround time on this one. Having now tested > it, I think that your solution is a much better one for the time > being, so please go ahead and apply it. From this discussion there are > a number of good options for improvements in the future, but my > priority would be to get the expanded version of the body passed to > org-confirm-babel-evaluate asap with as few disturbances to the rest > of the code base as possible. Best! All right, sounds good. Applied in df5a83637. Thanks.