From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id YKzOEBYYCWCEPgAA0tVLHw (envelope-from ) for ; Thu, 21 Jan 2021 05:58:46 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id qPeZDBYYCWCFKgAAB5/wlQ (envelope-from ) for ; Thu, 21 Jan 2021 05:58:46 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1A7C39402A7 for ; Thu, 21 Jan 2021 05:58:45 +0000 (UTC) Received: from localhost ([::1]:49186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l2SzT-0006kI-J0 for larch@yhetil.org; Thu, 21 Jan 2021 00:58:43 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40552) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l2SyW-0006gl-Ci for emacs-orgmode@gnu.org; Thu, 21 Jan 2021 00:57:45 -0500 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]:35153) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l2SyU-0006xK-P9 for emacs-orgmode@gnu.org; Thu, 21 Jan 2021 00:57:44 -0500 Received: by mail-pl1-x636.google.com with SMTP id g3so695769plp.2 for ; Wed, 20 Jan 2021 21:57:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=references:user-agent:from:to:cc:subject:date:in-reply-to :message-id:mime-version:content-transfer-encoding; bh=swosvGrLgfcMoG+4LEvT/Mr3sAQy+OIKh60zDGcIOGM=; b=AAQmSaxLqoCNdmL57ul0vcU+NpxnF2ykjvM7mgXRBOSpvIp7YEQEIPv/F095K1iC+D eRNeqhQWbkVa86sViLm2HbyC8LuKjKKt+GSV6NKeW2cmLdc92E0jLmZMRpzLjh+wYWya 8Hk8o/ICOkNlAbOTsyh6oXRsV4wPFJR2QdVqIKRU+sSNVZiaNI3nWTt89nKcZr4OIz71 yyhh8YTh+uBJLQtaRod2OPKOU3P1hqnap8kj6hkp/M+U6u0e5bIGc8xLQKGLFYZEWsFQ aWI3fC1HVXyy5vNebFRIueK9Fs1D8d2OPlyX23opMIk/BhrQoJ+TvmFu5dc0pGEtStyK Bq6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:references:user-agent:from:to:cc:subject:date :in-reply-to:message-id:mime-version:content-transfer-encoding; bh=swosvGrLgfcMoG+4LEvT/Mr3sAQy+OIKh60zDGcIOGM=; b=eGyZYocj4B7GPoGgY3bKbghti2+igw9lY7oXd1BvJqd/zJrX6/gqAVq5S08+ItwJ44 jfilXPbvxCJYILZlo51cvbsuvaV3oeXz6AO0xUAFktYZNDxnFMq/u9xD/AYl5dZojn4I 1HWAJxa9sVsCDznZ5mgJ5wtik4S1wPFR82NLtLELhVfxgF5uR4CIEoWgNTpoM1lRptTt 80D+6zInTC9J53KOgsQSoIegn8OWXNf9Svwf91d1s+hZoq2rKkYntZbrtklrDKPPhxKl 5zc+mXcMkCTFV0O2JcvYFaxD1gCclptnS/rW+9POQqUpAf83z7S2VlafS8DrrKskaupx SZnA== X-Gm-Message-State: AOAM533c+bpOvFN4S/SK8rmHnK2wN3koau5aH5iDlGGSPdptKfGGtggI qjHirNsMKzhNfN+PWWNiHUA= X-Google-Smtp-Source: ABdhPJyN+ND64RRDuRAR7F00oA53Tj5VxtGLapwdXL2fjYNsoiS65ayRV528jSKFZ+ioXnxtC74RJQ== X-Received: by 2002:a17:90a:5513:: with SMTP id b19mr9873607pji.99.1611208660940; Wed, 20 Jan 2021 21:57:40 -0800 (PST) Received: from localhost (180-150-91-8.b4965b.per.nbn.aussiebb.net. [180.150.91.8]) by smtp.gmail.com with ESMTPSA id v19sm4334013pjg.50.2021.01.20.21.57.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Jan 2021 21:57:40 -0800 (PST) References: <87pn6kfr19.fsf@gmail.com> <87blexel9f.fsf@gmail.com> <87im94ordh.fsf@gnu.org> <87tusolntx.fsf@wi.uni-muenster.de> <873607uw3y.fsf@gmail.com> <87im928ck3.fsf@wi.uni-muenster.de> <87k0tidxcf.fsf@gmail.com> <875z5287v1.fsf@wi.uni-muenster.de> <877dpdukkp.fsf@gmail.com> <84wnxccqa3.fsf@wi.uni-muenster.de> <874kjzb25d.fsf@gmail.com> <8735ziup6f.fsf@wi.uni-muenster.de> <87czymt6n1.fsf@gmail.com> <87zh1qrps8.fsf@wi.uni-muenster.de> <87ble5ucqk.fsf@gmail.com> <87ble5gort.fsf@wi.uni-muenster.de> <87o8hwpz34.fsf@gmail.com> <87lfd0hgi7.fsf@wi.uni-muenster.de> <87mtxgplz8.fsf@gmail.com> <87pn27st06.fsf@gmail.com> <87ft2vszmg.fsf@kyleam.com> User-agent: mu4e 1.4.14; emacs 27.1 From: TEC To: Kyle Meyer Subject: Re: [PATCH] Enhance org-html--build-meta-info Date: Thu, 21 Jan 2021 13:55:07 +0800 In-reply-to: <87ft2vszmg.fsf@kyleam.com> Message-ID: <87k0s64ysv.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::636; envelope-from=tecosaur@gmail.com; helo=mail-pl1-x636.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: org-mode-email Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -4.00 Authentication-Results: aspmx1.migadu.com; none X-Migadu-Queue-Id: 1A7C39402A7 X-Spam-Score: -4.00 X-Migadu-Scanner: scn1.migadu.com X-TUID: 8Nw2XCps/fgp Kyle Meyer writes: > I've applied this (a8df7670c) with two minor changes (shown in the diff > at end): s/with with/with/ in a docstring and move an element to its own > line to avoid the warning from lisp-mode's lisp--match-hidden-arg. Thanks :) > This thread has gone on long enough that I'll avoid requesting changes > for convention/style nits, but some things to keep in mind for future > patches: I'll try to keep these in mind in future. Might there be a Worg page or something listing all of these little things so I don't keep on being told of them a few at a time as I violate them? > Also, it'd be good for this to be accompanied by a NEWS entry. I'd > appreciated if that were sent in a separate thread, though. For some > reason I haven't debugged, my usual MUA can't load this thread. Will do =F0=9F=91=8D. -- Timothy