From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id UH2AOWboUWFxFAAAgWs5BA (envelope-from ) for ; Mon, 27 Sep 2021 17:51:02 +0200 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id UHwwNWboUWFZKAAAbx9fmQ (envelope-from ) for ; Mon, 27 Sep 2021 15:51:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 52D3F7F27 for ; Mon, 27 Sep 2021 17:51:02 +0200 (CEST) Received: from localhost ([::1]:47538 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUsuD-0006fO-CT for larch@yhetil.org; Mon, 27 Sep 2021 11:51:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUssz-0006Jg-W1 for emacs-orgmode@gnu.org; Mon, 27 Sep 2021 11:49:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60246) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mUssz-0001iS-GJ; Mon, 27 Sep 2021 11:49:45 -0400 Received: from [78.194.183.21] (port=59702 helo=hal) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mUssy-0006z5-Cq; Mon, 27 Sep 2021 11:49:44 -0400 Received: by hal (Postfix, from userid 1000) id B10781E041D; Mon, 27 Sep 2021 17:49:41 +0200 (CEST) From: Bastien To: No Wayman Subject: Re: [BUG] [BUG] inconsistent behavior when reading multiple tags [9.4.6 (9.4.6-g366444 @ /home/n/.emacs.d/straight/build/org/)] In-Reply-To: <87lf3idnz6.fsf@gmail.com> (No Wayman's message of "Mon, 27 Sep 2021 11:19:56 -0400") Organization: GNU References: <87a6l4b0bx.fsf@gmail.com> <80pmtqp2wx.fsf@felesatra.moe> <87ilzhjwkk.fsf@gmail.com> <87mtotcuf5.fsf@gmail.com> <87y28ddyby.fsf@gmail.com> <87mtnyquva.fsf@gnu.org> <87lf3idnz6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Date: Mon, 27 Sep 2021 17:49:41 +0200 Message-ID: <87k0j23tnu.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org, Allen Li Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1632757862; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post; bh=t4fsmxKVmYB83GDBDu7f3UnqKMGF/7Y/PtfTxEzwLWA=; b=HUr2epVhSVkgVkH36CuBZTggUF5zJqEU+1ay3/VqGZKhHT/08/pJ5LPV0u+Fdl6Brj4xXC 1tGk+33xRm/cmw55wGSKQNda58gZshPxEg+jUzdf6XR451m/56Ym4kC4hEZe/Jj3uLhky1 7dFpPUpy5YDYhQsHe6MRxgAUbJqnB/tldkrJAjLEu3DMfTfSuEkEJ1BQdATQur/nhcHqB7 tNSDeF3plQS6YoXxjI+gXXBfkmKa5PDjODgJ7mBjvgcKnCQ70M4tTSTLbeX9FP93V7g2wc 9VGnDHFc96ugQm2x5NFVlAs2fu+ivO3leJSBgoDfpF9lRICKY2xhrWApc7vRGA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1632757862; a=rsa-sha256; cv=none; b=dKkRaMVZs0Kl2umkkq9UlVTIN2rE95jAbdOBpKDEGIbnbutMKt3IF66Emgwsf2hWmhi2iW NANTL3aspSfFMDCdX2VekGheZ7OLw3isfB87UraqbbBWYAY9BbFleWFmhaH0MdPGIvjncT jk++h5GgNPPsvoO+UX7WXuG9dBYotFy1mTnv7WikEiZQUXWyzoZKTkRaoiEUAWv2htZ1kZ 1jx0KZoO/jSZo/bntuNPjkSJaPPTov3zM6NNDMlX58Xaq+SIcW0kPhiSB1LnLbKcg4bRwz WGvS5/l9GoP2xx0fH6qBM29PMbYpa1fI9YNQ9L6pFlB71mzaI9HpE4/2rThQ2Q== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=none; spf=pass (aspmx2.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -1.39 Authentication-Results: aspmx2.migadu.com; dkim=none; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx2.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 52D3F7F27 X-Spam-Score: -1.39 X-Migadu-Scanner: scn0.migadu.com X-TUID: MihObnZgdnwr Hi, No Wayman writes: > The patch you are viewing is outdated. > This is the latest patch on offer: > > https://list.orgmode.org/87bl4rce4j.fsf@gmail.com/2-0001-Allow-to-delimit-tags.patch Thanks. > It allows "," (the default for completing-read-multiple) and ":" to > delimit tags when completing-read-multiple is used. What does not work if we don't allow ","? > The reason for allowing "," is that it's easier to type than ":". I > make liberal use of tags and IMO typing a "Shift+;" between each tag > is annoying and slow. Okay (but note that we don't all use the same keyboard...) > The comma is also used as the default separator when > completing-read-multiple is used. > >> If we relax a constraint, I'd rather have this hardcoded and well >> documented than adding a new defvar or defcustom. > > The latest patch removed the defcustom and replaced it with a defvar > for the crm-separator regexp. > If it would ease your mind I'd be happy to convert it to a defconst. Instead of a defvar that we don't want the user to modify, why not hardcoding the addition of the coma? I'd prefer this. > It's also worth noting that the constraint was only recently > introduced. > "," worked fine to delimit tags in `org-set-tags-command' prior to the > switch to completing-read-multiple. Okay, this buys it - if I understand what really does not work when allowing ":". > Regarding documentation, let me know where you'd prefer it > documented. Any place in the manual that refers to tag separators, explicitely or implicitely, I've not checked if there are some. Also in the code itself, as a comment, to explain why both "," and ":" should be allowed (avoid the keyboard-based argument, which is too subjective.) Thanks! -- Bastien