From: "Juan Manuel Macías" <email@example.com> To: Ihor Radchenko <firstname.lastname@example.org> Cc: orgmode <email@example.com> Subject: Re: [PATCH] speed commands: error message when a key is not associated with a command Date: Sat, 30 Apr 2022 14:41:02 +0000 [thread overview] Message-ID: <firstname.lastname@example.org> (raw) In-Reply-To: <87y1zm7ma5.fsf@localhost> (Ihor Radchenko's message of "Sat, 30 Apr 2022 21:06:58 +0800") Ihor Radchenko writes: > Note that speed commands are not only decided by > org-speed-command-activate. Any function in org-speed-command-hook can > trigger speed command. Throwing an error in org-speed-command-activate > can potentially shadow other functions in the hook. Ah, I see... I had not taken into account what you mention. But, if I have understood correctly how this hook works, each associated function has its "independence", right? I mean, if I have org-speed-command-activate and org-babel-speed-command-activate associated to this hook, and I bind the "K" key to an action in org-babel-key-bindings, but that key does not is associated with any action in org-speed-commands, then the error message would only be displayed in the proper context, that is, if I hit K at the beginning of the headline or any location defined for org-use-speed-commands. Another possibility I can think of is, instead of returning an error message: just do nothing when a wrong key is pressed. Something, maybe, like this (I suppose that the same should be done in each function added to the hook): ... (let ((defined (cdr (assoc keys ;; FIXME: don't check `org-speed-commands-user' past 9.6 (if (boundp 'org-speed-commands-user) (append org-speed-commands org-speed-commands-user) org-speed-commands))))) (if defined defined 'ignore)))) I don't know if this would avoid unexpected results... what do you think? Best regards, Juan Manuel
next prev parent reply other threads:[~2022-04-30 14:41 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-30 11:25 Juan Manuel Macías 2022-04-30 13:06 ` Ihor Radchenko 2022-04-30 14:41 ` Juan Manuel Macías [this message] 2022-04-30 19:39 ` Juan Manuel Macías 2022-05-01 4:01 ` Ihor Radchenko 2022-05-01 11:00 ` Juan Manuel Macías 2022-05-02 3:31 ` Ihor Radchenko 2022-05-03 23:08 ` Juan Manuel Macías
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: https://www.orgmode.org/ * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --subject='Re: [PATCH] speed commands: error message when a key is not associated with a command' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox: https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).