emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Ihor Radchenko <yantar92@gmail.com>
To: "Rudolf Adamkovič" <salutis@me.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: Propertize some navigational keybindings
Date: Sat, 08 Oct 2022 15:03:28 +0800	[thread overview]
Message-ID: <87k05akda7.fsf@localhost> (raw)
In-Reply-To: <m2v8ovisaw.fsf@me.com>

Rudolf Adamkovič <salutis@me.com> writes:

> Howdy, howdy!
>
> Please review the attached patch that propertizes (i.e. adds style to)
> the navigational keybindings displayed in the header of the Org Export
> dispatch UI.

Thanks!

> +	(setq cursor-type nil)
> +        (setq header-line-format
> +              (apply 'format
> +                     (cons "Use %s, %s, %s, or %s to navigate."
> +                           (mapcar (lambda (key)
> +                                     (propertize key 'face 'help-key-binding))
> +                                   (list "SPC" "DEL" "C-n" "C-p")))))

I think that the most thorough way to add this feature is following what
`help--key-description-fontified' does (we should not call this internal
function though):

(defun help--key-description-fontified (keys &optional prefix)
  "Like `key-description' but add face for \"*Help*\" buffers.
KEYS is the return value of `(where-is-internal \\='foo-cmd nil t)'.
Return nil if KEYS is nil."
  (when keys
    ;; We add both the `font-lock-face' and `face' properties here, as this
    ;; seems to be the only way to get this to work reliably in any
    ;; buffer.
    (propertize (key-description keys prefix)
                'font-lock-face 'help-key-binding
                'face 'help-key-binding)))

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>

next prev parent reply	other threads:[~2022-10-08  7:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-07 15:09 Propertize some navigational keybindings Rudolf Adamkovič
2022-10-08  7:03 ` Ihor Radchenko [this message]
2022-10-08 20:42   ` Rudolf Adamkovič
2022-10-09  7:47     ` Ihor Radchenko
2022-10-09  7:48     ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k05akda7.fsf@localhost \
    --to=yantar92@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=salutis@me.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).