emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: gerard.vermeulen@posteo.net
Cc: Emacs orgmode <emacs-orgmode@gnu.org>, dto@gnu.org
Subject: Re: [PATCH] In case of Sly, let org-babel-execute:lisp use Slynk instead of Swank
Date: Wed, 29 Mar 2023 09:42:49 +0000	[thread overview]
Message-ID: <87jzyzx59i.fsf@localhost> (raw)
In-Reply-To: <480536eb12bf49144384f4b1a85d8bdf@posteo.net>

gerard.vermeulen@posteo.net writes:

> The Emacs integrated development environments Slime and Sly
> communicate by means of similar RPC protocols with different server
> programs: Swank in case of Slime and Slynk in case of Sly.  However,
> the code in org-babel-execute:lisp always expects to talk with Swank
> because of the hard-coded call to swank:eval-and-grab-output.
>
> After starting a Sly REPL, calls to swank:eval-and-grab-output do not
> talk with the Slynk server started by the Sly REPL.
>
> The attached patch "soft-codes" eval-and-grab-output to become
> swank:eval-and-grab-output when using Slime and
> slynk:eval-and-grab-output when using Sly.

I do not use ob-lisp, but this patch looks reasonable.

I'd appreciate if other ob-lisp users could test the patch with both SLY
and SLIME.

I have no comments on the Elisp part of the patch.

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2023-03-29  9:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-29  8:11 [PATCH] In case of Sly, let org-babel-execute:lisp use Slynk instead of Swank gerard.vermeulen
2023-03-29  9:42 ` Ihor Radchenko [this message]
2023-03-30  4:56   ` gerard.vermeulen
2023-03-30 10:10     ` Ihor Radchenko
2023-05-02 12:15       ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87jzyzx59i.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=dto@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=gerard.vermeulen@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).