From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id mCjSHNfNvGTdHAEASxT56A (envelope-from ) for ; Sun, 23 Jul 2023 08:51:03 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oC3KHNfNvGSzLAEA9RJhRA (envelope-from ) for ; Sun, 23 Jul 2023 08:51:03 +0200 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2AEDB340DC for ; Sun, 23 Jul 2023 08:50:58 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=rdwoihYV; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1690095058; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=lkKs0TGAnn9Xu5SqxRxgMFakHbZ5ooD25VH92SDzNb0=; b=lvub4/8IG6FSwbai6vDuS3gmrqdtDSWIOpkZK3ph0wr6sdH8RQTOFI8YXcmWp+dVUg0CR7 1VvyiqCjmZ+31krchZWZ40bFvV/0CwK2eSvqe1bBPH6F5rBrRk/eEKOx9QbZk/eTVQyeW1 4OPm/GZggkccn1gA8NEY/Mg2QDsHJX9YcSiSBW9C34Sn89WSWnuH7/orjKu5WeDMO8BEU7 SKz64a+16ThkA35gimHaJkC9Uu0zTHIqYB5vNUKAoeDGJy+SYbGE++vy3++WFBYecZBKn9 3j0W9VvQ9FfZ8ov25eo+wX7vhSbobZzeIhmQhPXrL3nTC1A6P3+5HXXPaQrNQg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1690095058; a=rsa-sha256; cv=none; b=RWXFW/SbPL/kjIocd3t9g3RmdJ6ZMSY6YuF70U2O9NU1r0oaoQ21/hD4pM7BYQNFVAfFDj hHA9nGxC+52N5RbYpqFjKRp5aMc0X/lUMAUp0z0yvWb1q0aIFlNCRSfUHEJsL9SzRUqGtH ZEaIvGM+KtkVp0ih67Nx2fByxbC/v7H5EBxP1dbhW8axJ0ECKRhd5kEJ/bbE4jAyemBS4s yQWddDJjgC0gT3Pz4wT+yy8Kn2RFuAk+ADHdAN8zt+uosRPV7arnfh6L9MBfPVA4NVD58T L4Fp3wzOyH7CXjXhIZLtz0bzz7d2B5jRPwrac/Ym8EyVVQ2s3tb/jxY9oAD8KQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=rdwoihYV; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org"; dmarc=pass (policy=none) header.from=posteo.net Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qNSvB-0003YS-Qw; Sun, 23 Jul 2023 02:50:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNSv0-0003Xo-JP for emacs-orgmode@gnu.org; Sun, 23 Jul 2023 02:50:18 -0400 Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qNSud-00033A-Gp for emacs-orgmode@gnu.org; Sun, 23 Jul 2023 02:50:06 -0400 Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 56E97240027 for ; Sun, 23 Jul 2023 08:49:48 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1690094988; bh=bNYB+ZY+k+kHHgWdf5oXLIo8kOAvd/MCzjG6z5HpVCo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=rdwoihYVpMLW8sP7wtWrUjcLjTmPB57DOyEcdLRg4REdit/k24IRhw3t8gTQtZTJL 1atLv2tdsE1b9vIokaeeYhqTAIpz2mvbncY19HJrAauEu7dHf8YAr4SuUmhE9D7g/q FQ6INrBYu+0q6xKsXADd8A9ZLRMJD7M7RkMdWgvWcnqva9j61EynWQE7PUzgVGPMnd aRIecb6/kQBjkEdKyDO2EgIO0VVP80XPSqaCHOBENn+WnkRbAiQqzCExCTaS/cGvJU g/u+k/zOBd4kizuFqigpUujdUdfCnSDmo8f4hiMvTZhYG+FbWahsEhNvvetWnr0l+s sg8vjP2gb59lQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4R7v6g4XXRz9rxl; Sun, 23 Jul 2023 08:49:47 +0200 (CEST) From: Ihor Radchenko To: Gavin Downard Cc: Max Nikulin , emacs-orgmode@gnu.org Subject: Re: [PATCH] lisp/org-table.el: Allow named columns on lhs In-Reply-To: <87bkg3hga5.fsf@runbox.com> References: <877cqwbpa2.fsf@runbox.com> <87bkg3hga5.fsf@runbox.com> Date: Sun, 23 Jul 2023 06:50:01 +0000 Message-ID: <87jzurrujq.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx2.migadu.com X-Migadu-Spam-Score: -8.97 X-Spam-Score: -8.97 X-Migadu-Queue-Id: 2AEDB340DC X-TUID: g+Lnz38AmO0f Gavin Downard writes: >> Notice >> "Double definition `%s=' in TBLFM line, please fix by hand" >> >> below. A bit more code is required to keep this sanity check for named columns. >> > > Oh, good catch. Specifically, I think this should be caught inside of > `org-table-recalculate', where it catches conflicting direct column > references (eg "$1") and end-relative column references ("$<"). Do we have any tests covering this part of the code? >> `if-let' is not available in Emacs-26 >> > > Are you sure? It looks like `if-let' was introduced in Emacs 25. In Emacs 26, we will need (require 'subr-x), but otherwise it is not a problem to use `if-let'. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at