From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Lundin Subject: Re: Problems with (defvar foo) and Emacs 23 Date: Sat, 07 Apr 2012 07:15:30 -0500 Message-ID: <87iphbrb4t.fsf@fastmail.fm> References: <87sjgngtzk.fsf@norang.ca> <87aa2vp5ri.fsf@Rainer.invalid> <87bona64ri.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Return-path: Received: from eggs.gnu.org ([208.118.235.92]:34106) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SGUYK-0006L0-Pb for emacs-orgmode@gnu.org; Sat, 07 Apr 2012 08:15:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SGUYJ-0003ZX-1H for emacs-orgmode@gnu.org; Sat, 07 Apr 2012 08:15:36 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SGUYI-0003ZO-NL for emacs-orgmode@gnu.org; Sat, 07 Apr 2012 08:15:34 -0400 Received: from compute2.internal (compute2.nyi.mail.srv.osa [10.202.2.42]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 291E122099 for ; Sat, 7 Apr 2012 08:15:32 -0400 (EDT) In-Reply-To: <87bona64ri.fsf@gnu.org> (Bastien's message of "Mon, 02 Apr 2012 08:12:49 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: Achim Gratz , emacs-orgmode@gnu.org --=-=-= Content-Type: text/plain Bastien writes: > > I fixed the problem with `org-clock-state'. This should be `org-state'. > > `state' is a local variable in many org.el functions, I renamed it to > `org-state' in org-clock.el and in "caller" sexp from org.el. > Attached please find a patch that fixes the docstring of org-after-todo-state-change-hook to reflect this change. Best, Matt --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Fix-hook-docstring-to-reflect-renaming-of-state-to-o.patch >From f21889985f2008bc77e2ecfc38be481a47c9916c Mon Sep 17 00:00:00 2001 From: Matt Lundin Date: Sat, 7 Apr 2012 07:13:55 -0500 Subject: [PATCH] Fix hook docstring to reflect renaming of state to org-state. * lisp/org.el: (org-after-todo-state-change-hook): Fix docstring to reflect name change of state to org-state. The renamed variable can cause user hooks added to org-after-todo-state-change-hook to break, so it is essential to have the correct variable name in the docstring. --- lisp/org.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/org.el b/lisp/org.el index a11d734..e7c579d 100644 --- a/lisp/org.el +++ b/lisp/org.el @@ -2231,7 +2231,7 @@ property and include the word \"recursive\" into the value." (defcustom org-after-todo-state-change-hook nil "Hook which is run after the state of a TODO item was changed. The new state (a string with a TODO keyword, or nil) is available in the -Lisp variable `state'." +Lisp variable `org-state'." :group 'org-todo :type 'hook) -- 1.7.10 --=-=-=--