emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: James Harkins <jamshark70@gmail.com>
To: Bastien <bzg@gnu.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: MobileOrg and tags
Date: Fri, 03 Aug 2012 11:41:38 -0400	[thread overview]
Message-ID: <87ipd06kzx.wl%jamshark70@dewdrop-world.net> (raw)
In-Reply-To: <87pq78rwbz.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 722 bytes --]

At Fri, 03 Aug 2012 14:31:12 +0200,
Bastien wrote:
> I've finally committed a change for this, using
> `org-global-tags-completion-table' inconditionnally.
> 
> Please test it and report any problem.

Sorry I was late in delivering the patch. How about this (to apply on top of 7.8.11)? If it doesn't apply to master, I can regenerate it against the master branch. Let me know.

hjh


--
James Harkins /// dewdrop world
jamshark70@dewdrop-world.net
http://www.dewdrop-world.net

"Come said the Muse,
Sing me a song no poet has yet chanted,
Sing me the universal."  -- Whitman

blog: http://www.dewdrop-world.net/words
audio clips: http://www.dewdrop-world.net/audio
more audio: http://soundcloud.com/dewdrop_world/tracks


[-- Attachment #2: 0001-Add-rebuild-tag-list-defcustom-and-implement-in-org-.patch --]
[-- Type: text/plain, Size: 1902 bytes --]

From 0e5b879eff9c7d7a09cbb721c763455fc14854e1 Mon Sep 17 00:00:00 2001
From: James Harkins <jamshark70@dewdrop-world.net>
Date: Wed, 1 Aug 2012 21:12:01 -0400
Subject: [PATCH] Add rebuild-tag-list defcustom and implement in
 org-mobile-create-index-file

org-mobile-rebuild-tag-list is a boolean.

If true, it calls org-global-tags-completion-table to
generate a complete list of tags used in agenda files,
to put into index.org.

If false, it uses org-tag-alist-for-agenda instead (saving time).
---
 lisp/org-mobile.el |   17 ++++++++++++++++-
 1 file changed, 16 insertions(+), 1 deletion(-)

diff --git a/lisp/org-mobile.el b/lisp/org-mobile.el
index 946e821..2105c5f 100644
--- a/lisp/org-mobile.el
+++ b/lisp/org-mobile.el
@@ -214,6 +214,18 @@ For now, it is not recommended to change this variable."
   :group 'org-mobile
   :type 'string)
 
+(defcustom org-mobile-rebuild-tag-list t
+  "If non-nil, use (org-global-tags-completion-table) to populate the list
+of all tags used in all agenda files. This ensures that all tags are available
+on the mobile device.
+
+If the agenda files are very large, this could be time consuming. Set to nil
+to disable the automatic generation of the list. You may then supply the tag list
+manually by populating org-tag-alist-for-agenda."
+  :type 'boolean
+  :group 'org-mobile
+)
+
 (defvar org-mobile-pre-push-hook nil
   "Hook run before running `org-mobile-push'.
 This could be used to clean up `org-mobile-directory', for example to
@@ -430,7 +442,10 @@ agenda view showing the flagged items."
 			       ((listp e)
 				(if (stringp (car e)) (car e) nil))
 			       (t nil)))
-		       org-tag-alist-for-agenda))))
+		       (if org-mobile-rebuild-tag-list
+			   (org-global-tags-completion-table)
+			 org-tag-alist-for-agenda)
+		       ))))
     (with-temp-file
 	(if org-mobile-use-encryption
 	    org-mobile-encryption-tempfile
-- 
1.7.9.5


  reply	other threads:[~2012-08-03 15:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-17  2:34 MobileOrg and tags James Harkins
2012-07-20 16:20 ` James Harkins
2012-07-28 17:49   ` Bastien
2012-07-29 20:22     ` James Harkins
2012-07-30 10:20       ` Bastien
2012-08-03 12:31         ` Bastien
2012-08-03 15:41           ` James Harkins [this message]
2012-08-03 16:16             ` Bastien
2012-08-03 17:02               ` James Harkins
2012-08-03 17:09                 ` Bastien
2012-08-03 18:06                 ` Bastien
2012-08-03 18:50                   ` James Harkins
2012-08-04  8:24                     ` Bastien
2012-08-04  8:24                     ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipd06kzx.wl%jamshark70@dewdrop-world.net \
    --to=jamshark70@gmail.com \
    --cc=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).