From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <n.goaziou@gmail.com>
Subject: Re: [PATCH] Escape slashes in ARCHIVE_OLPATH
Date: Fri, 09 Nov 2012 09:57:04 +0100
Message-ID: <87ip9fjgrj.fsf@gmail.com>
References: <CAPM+gBQ_xo-rtGNjjybjj_4ZWC5DkYnrqnhqqpx7o8yg2Lng4g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:36564)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1TWkSo-0003pd-Md
	for emacs-orgmode@gnu.org; Fri, 09 Nov 2012 04:01:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1TWkSn-00080A-LO
	for emacs-orgmode@gnu.org; Fri, 09 Nov 2012 04:01:22 -0500
Received: from mail-we0-f169.google.com ([74.125.82.169]:64686)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <n.goaziou@gmail.com>) id 1TWkSn-0007zw-1r
	for emacs-orgmode@gnu.org; Fri, 09 Nov 2012 04:01:21 -0500
Received: by mail-we0-f169.google.com with SMTP id u3so1973679wey.0
	for <emacs-orgmode@gnu.org>; Fri, 09 Nov 2012 01:01:20 -0800 (PST)
In-Reply-To: <CAPM+gBQ_xo-rtGNjjybjj_4ZWC5DkYnrqnhqqpx7o8yg2Lng4g@mail.gmail.com>
	(Takafumi Arakaki's message of "Mon, 5 Nov 2012 14:13:52 +0100")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Takafumi Arakaki <aka.tkf@gmail.com>
Cc: emacs-orgmode@gnu.org

Hello,

Takafumi Arakaki <aka.tkf@gmail.com> writes:

> Currently information about tree structure is lost if you have a slash
> in node headings.  This patch fixes the problem by escaping slashes in
> headings before concatenating them.

Thanks for your patch.

Would you mind providing a test-case to illustrate the problem? Also,
could you provide a change log entry for the patch (and use git
format-patch if possible)?

> +	    (olpath (mapconcat
> +		     (lambda (s)
> +		       (setq s (replace-regexp-in-string "\\\\" "\\\\\\\\" s))
> +		       (setq s (replace-regexp-in-string "/" "\\\\/" s))
> +		       s)

I'd rather nest the `replace-regexp-in-string' instead of setq'ing twice
in a row the same variable. I.e:

  (replace-regexp-in-string
   "/" "\\\\/" (replace-regexp-in-string "\\\\" "\\\\\\\\" s))


Regards,

-- 
Nicolas Goaziou