From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH 2/2] Orgpan: quiet byte-compiler Date: Sat, 22 Dec 2012 16:13:20 +0100 Message-ID: <87ip7ty821.fsf@bzg.ath.cx> References: <87lifnn089.fsf@bernoul.li> <1351368433-4558-1-git-send-email-jonas@bernoul.li> <1351368433-4558-3-git-send-email-jonas@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:51388) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TmYim-00041e-SB for emacs-orgmode@gnu.org; Sat, 22 Dec 2012 18:43:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TmYig-0005XJ-JM for emacs-orgmode@gnu.org; Sat, 22 Dec 2012 18:43:12 -0500 Received: from mail-we0-f175.google.com ([74.125.82.175]:35992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TmYig-0005XF-CR for emacs-orgmode@gnu.org; Sat, 22 Dec 2012 18:43:06 -0500 Received: by mail-we0-f175.google.com with SMTP id z53so2771702wey.6 for ; Sat, 22 Dec 2012 15:43:05 -0800 (PST) In-Reply-To: <1351368433-4558-3-git-send-email-jonas@bernoul.li> (Jonas Bernoulli's message of "Sat, 27 Oct 2012 22:07:13 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Jonas Bernoulli Cc: lennart.borgman@gmail.com, emacs-orgmode@gnu.org Hi Jonas, Jonas Bernoulli writes: > * contrib/lisp/org-panel.el: don't setq undefined and otherwise unused > variable orgpan-this-panel-window > * contrib/lisp/org-panel.el (orgpan-check-panel-mode): fix format > string of (error) > * contrib/lisp/org-panel.el: declare variables > viper-emacs-state-mode-list and viper-new-major-mode-buffer-list > which are defined in viper.el > > TINYCHANGE Applied to master, thanks. PS: Commit changelogs should use proper sentences: uppercase letter at the beginning, full-stop at the end, two spaces between sentences. Not that a problem for commits that go into contrib/, but important for those going into Org's core. Thanks for thinking of it! Also, I added you to the list of FSF-signed contributors on Worg: http://orgmode.org/worg/org-contribute.html#contributors_with_fsf_papers -- Bastien