From: Bastien <bzg@altern.org>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: lennart.borgman@gmail.com, emacs-orgmode@gnu.org
Subject: Re: [PATCH 2/2] Orgpan: quiet byte-compiler
Date: Sat, 22 Dec 2012 16:13:20 +0100 [thread overview]
Message-ID: <87ip7ty821.fsf@bzg.ath.cx> (raw)
In-Reply-To: <1351368433-4558-3-git-send-email-jonas@bernoul.li> (Jonas Bernoulli's message of "Sat, 27 Oct 2012 22:07:13 +0200")
Hi Jonas,
Jonas Bernoulli <jonas@bernoul.li> writes:
> * contrib/lisp/org-panel.el: don't setq undefined and otherwise unused
> variable orgpan-this-panel-window
> * contrib/lisp/org-panel.el (orgpan-check-panel-mode): fix format
> string of (error)
> * contrib/lisp/org-panel.el: declare variables
> viper-emacs-state-mode-list and viper-new-major-mode-buffer-list
> which are defined in viper.el
>
> TINYCHANGE
Applied to master, thanks.
PS: Commit changelogs should use proper sentences: uppercase letter at
the beginning, full-stop at the end, two spaces between sentences. Not
that a problem for commits that go into contrib/, but important for
those going into Org's core. Thanks for thinking of it!
Also, I added you to the list of FSF-signed contributors on Worg:
http://orgmode.org/worg/org-contribute.html#contributors_with_fsf_papers
--
Bastien
prev parent reply other threads:[~2012-12-22 23:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-03 13:32 [PATCH] Orgpan: resize the correct window Jonas Bernoulli
2012-10-03 13:47 ` Jonas Bernoulli
2012-10-26 13:10 ` Bastien
2012-10-27 20:07 ` [PATCH 0/2] Orgpan: resize " Jonas Bernoulli
2012-10-27 20:07 ` [PATCH 1/2] Orgpan: resize the " Jonas Bernoulli
2012-12-22 15:11 ` Bastien
2012-10-27 20:07 ` [PATCH 2/2] Orgpan: quiet byte-compiler Jonas Bernoulli
2012-12-22 15:13 ` Bastien [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ip7ty821.fsf@bzg.ath.cx \
--to=bzg@altern.org \
--cc=emacs-orgmode@gnu.org \
--cc=jonas@bernoul.li \
--cc=lennart.borgman@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).