* [PATCH] Avoid modification hooks in org-clock-sum
@ 2013-01-31 9:38 Francesco Pizzolante
2013-01-31 13:19 ` Bastien
0 siblings, 1 reply; 4+ messages in thread
From: Francesco Pizzolante @ 2013-01-31 9:38 UTC (permalink / raw)
To: mailing-list-org-mode
Hello,
This patch avoid modification hooks to be run in org-clock-sum by using
org-unmodified (instead of simply saving and restoring buffer-modified-p).
On my system, this speeds up the creation of clock reports.
I should have indented the code but I didn't in order to respect the
less-than-20-lines change (I have no copyright assignment to the FSF yet).
Regards,
Francesco
From b328fadfbc76143ab86286f8a9939fa2c49ba186 Mon Sep 17 00:00:00 2001
From: Francesco Pizzolante <fpz-djc/iPCCuDYQheJpep6IedvLeJWuRmrY@public.gmane.org>
Date: Wed, 30 Jan 2013 17:21:42 +0100
Subject: [PATCH] Avoid Protect org-clock-sum using org-unmodified
* org-clock.el (org-clock-sum): Avoid modification hooks in org-clock-sum
TINYCHANGE
---
lisp/org-clock.el | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/lisp/org-clock.el b/lisp/org-clock.el
index 7bd5b5a..945fcd0 100644
--- a/lisp/org-clock.el
+++ b/lisp/org-clock.el
@@ -1675,8 +1675,8 @@ each headline in the time range with point at the headline. Headlines for
which HEADLINE-FILTER returns nil are excluded from the clock summation.
PROPNAME lets you set a custom text property instead of :org-clock-minutes."
(interactive)
- (let* ((bmp (buffer-modified-p))
- (re (concat "^\\(\\*+\\)[ \t]\\|^[ \t]*"
+ (org-unmodified
+ (let* ((re (concat "^\\(\\*+\\)[ \t]\\|^[ \t]*"
org-clock-string
"[ \t]*\\(?:\\(\\[.*?\\]\\)-+\\(\\[.*?\\]\\)\\|=>[ \t]+\\([0-9]+\\):\\([0-9]+\\)\\)"))
(lmax 30)
@@ -1753,8 +1753,7 @@ PROPNAME lets you set a custom text property instead of :org-clock-minutes."
(setq t1 0)
(loop for l from level to (1- lmax) do
(aset ltimes l 0)))))))
- (setq org-clock-file-total-minutes (aref ltimes 0)))
- (set-buffer-modified-p bmp)))
+ (setq org-clock-file-total-minutes (aref ltimes 0))))))
(defun org-clock-sum-current-item (&optional tstart)
"Return time, clocked on current item in total."
--
1.7.9
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Avoid modification hooks in org-clock-sum
2013-01-31 9:38 [PATCH] Avoid modification hooks in org-clock-sum Francesco Pizzolante
@ 2013-01-31 13:19 ` Bastien
[not found] ` <87ip6djxrj.fsf-E3UqQZAQFPqWIDz0JBNUog@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Bastien @ 2013-01-31 13:19 UTC (permalink / raw)
To: Francesco Pizzolante; +Cc: mailing-list-org-mode
Hi Francesco,
"Francesco Pizzolante"
<fpz-djc/iPCCuDYQheJpep6IedvLeJWuRmrY@public.gmane.org> writes:
> This patch avoid modification hooks to be run in org-clock-sum by using
> org-unmodified (instead of simply saving and restoring buffer-modified-p).
>
> On my system, this speeds up the creation of clock reports.
Applied, thanks.
> I should have indented the code but I didn't in order to respect the
> less-than-20-lines change (I have no copyright assignment to the FSF yet).
Please let me know if you want to assign your copyright for
further patches -- the limit is cumulative over patches.
Thanks!
--
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Avoid modification hooks in org-clock-sum
[not found] ` <87ip6djxrj.fsf-E3UqQZAQFPqWIDz0JBNUog@public.gmane.org>
@ 2013-01-31 15:21 ` Francesco Pizzolante
2013-01-31 18:10 ` Bastien
0 siblings, 1 reply; 4+ messages in thread
From: Francesco Pizzolante @ 2013-01-31 15:21 UTC (permalink / raw)
To: Bastien; +Cc: mailing-list-org-mode, Francesco Pizzolante
Hi Bastien,
> Applied, thanks.
Thanks to you.
> Please let me know if you want to assign your copyright for
> further patches -- the limit is cumulative over patches.
I just introduced a request to the FSF.
Regards,
Francesco
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Avoid modification hooks in org-clock-sum
2013-01-31 15:21 ` Francesco Pizzolante
@ 2013-01-31 18:10 ` Bastien
0 siblings, 0 replies; 4+ messages in thread
From: Bastien @ 2013-01-31 18:10 UTC (permalink / raw)
To: Francesco Pizzolante; +Cc: mailing-list-org-mode, Francesco Pizzolante
Hi Francesco,
"Francesco Pizzolante" <fpz@missioncriticalit.com> writes:
>> Please let me know if you want to assign your copyright for
>> further patches -- the limit is cumulative over patches.
>
> I just introduced a request to the FSF.
I've updated the Worg page:
http://orgmode.org/worg/org-contribute.html#sec-6-2
Thanks!
--
Bastien
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-01-31 18:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-01-31 9:38 [PATCH] Avoid modification hooks in org-clock-sum Francesco Pizzolante
2013-01-31 13:19 ` Bastien
[not found] ` <87ip6djxrj.fsf-E3UqQZAQFPqWIDz0JBNUog@public.gmane.org>
2013-01-31 15:21 ` Francesco Pizzolante
2013-01-31 18:10 ` Bastien
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).