From mboxrd@z Thu Jan 1 00:00:00 1970 From: Derek Upham Subject: Re: org-agenda-show-log, org-timeline bugs Date: Thu, 07 Feb 2013 07:00:34 -0800 Message-ID: <87ip64184t.fsf@priss.frightenedpiglet.com> References: <87sj5cjx5w.fsf@priss.frightenedpiglet.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([208.118.235.92]:55604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U3Sxz-00013A-0D for emacs-orgmode@gnu.org; Thu, 07 Feb 2013 10:00:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U3Sxv-0000ZY-M6 for emacs-orgmode@gnu.org; Thu, 07 Feb 2013 10:00:46 -0500 Received: from smtp61.avvanta.com ([206.124.128.61]:33070 helo=mail.avvanta.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U3Sxv-0000ZF-CB for emacs-orgmode@gnu.org; Thu, 07 Feb 2013 10:00:43 -0500 Received: from mail.avvanta.com (localhost.rowlf.p [127.0.0.1]) by mail.avvanta.com (Postfix) with ESMTP id 739C593C5A for ; Thu, 7 Feb 2013 07:00:42 -0800 (PST) Received: from priss.frightenedpiglet.com (c-24-16-15-52.hsd1.wa.comcast.net [24.16.15.52]) by mail.avvanta.com (Postfix) with ESMTP id 5650993C52 for ; Thu, 7 Feb 2013 07:00:42 -0800 (PST) Received: from localhost ([127.0.0.1] helo=priss.frightenedpiglet.com) by priss with esmtp (Exim 4.80) (envelope-from ) id 1U3Sxm-0000fa-OY for emacs-orgmode@gnu.org; Thu, 07 Feb 2013 07:00:34 -0800 In-reply-to: <87sj5cjx5w.fsf@priss.frightenedpiglet.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Can someone please verify these bugs? Thanks. Derek Derek Upham writes: > I tried running org-timeline on an Org file with lots of timestamped > TODO -> DONE state changes, and didn't see the matches I was expecting. > While poking around, I found two problems. > > 1. `org-timeline' isn't setting the text properties necessary to refresh > the timeline buffer. This means that none of the special keys to update > the display actually work. Here's the `org-timeline' version: > > (add-text-properties (point-min) (point-max) '(org-agenda-type timeline)) > > Here's the same chunk in `org-agenda-list' for comparison: > > (add-text-properties (point-min) (point-max) > `(org-agenda-type agenda > org-last-args (,arg ,start-day ,span) > org-redo-cmd ,org-agenda-redo-command > org-series-cmd ,org-cmd)) > > 2. Even when the `org-timeline' function has refresh set up properly, > `org-agenda-log-mode' (via the `l' hotkey) doesn't work. It looks like > the function changes the buffer-local copy of the `org-agenda-show-log' > variable, but the refresh code looks at the global version of the > variable (possibly because the refresh is happening through eval?). In > order to see the log entries, you need to set `org-agenda-show-log' > outside of the timeline buffer (using `setq'). > > Can someone take a look at these? This is all with the latest sources > from the repo. Thanks. > > Derek