emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Nicolas Goaziou <n.goaziou@gmail.com>
To: Carsten Dominik <carsten.dominik@gmail.com>
Cc: Org-mode List <emacs-orgmode@gnu.org>
Subject: Re: Exporter interface question
Date: Thu, 28 Feb 2013 11:22:06 +0100	[thread overview]
Message-ID: <87ip5cpwkx.fsf@gmail.com> (raw)
In-Reply-To: <BE6C7742-48F1-4E2A-874F-8D528206FC7F@gmail.com> (Carsten Dominik's message of "Thu, 28 Feb 2013 09:39:18 +0100")

Hello,

Carsten Dominik <carsten.dominik@gmail.com> writes:

> OK, I pushed this change, maybe it is good if you have a brief look,
> Nicolas.

Thanks for the patch. It looks good. I have one minor suggestion,
though. In the following snippet:

  (eq (marker-buffer org-export-dispatch-last-position)
  		   (current-buffer))

wouldn't it be better to check equality with:

  (org-base-buffer (current-buffer))

instead or simply (current-buffer)?

> It was great fun and educational to study your very clear code.

Thank you. 


Regards,

-- 
Nicolas Goaziou

next prev parent reply	other threads:[~2013-02-28 10:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-27  8:04 Exporter interface question Carsten Dominik
2013-02-27  8:52 ` Nicolas Goaziou
2013-02-27 12:00   ` Carsten Dominik
2013-02-27 12:25     ` Suvayu Ali
2013-02-27 15:02   ` Carsten Dominik
2013-02-27 15:22     ` Nicolas Goaziou
2013-02-28  8:39       ` Carsten Dominik
2013-02-28  9:05         ` Carsten Dominik
2013-02-28 10:22         ` Nicolas Goaziou [this message]
2013-02-28 11:50           ` Carsten Dominik
2013-02-28 12:30             ` Nicolas Goaziou
2013-02-28 18:52               ` Carsten Dominik
2013-02-28 21:10                 ` Nicolas Goaziou
2013-03-04  9:17                   ` Carsten Dominik
2013-03-04 14:45                     ` Nicolas Goaziou
2013-03-04 19:21                       ` Carsten Dominik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ip5cpwkx.fsf@gmail.com \
    --to=n.goaziou@gmail.com \
    --cc=carsten.dominik@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).