From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bastien <bzg@altern.org>
Subject: Re: RFQ - new contribution - org-screenshot.el
Date: Fri, 17 May 2013 15:49:18 +0200
Message-ID: <87ip2hogwx.fsf@bzg.ath.cx>
References: <87mwru8f57.wl%max@openchat.com> <874ne23zir.fsf@bzg.ath.cx>
	<87ppwqawei.fsf@krugs.de> <87li7d99db.wl%max@openchat.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([208.118.235.92]:54061)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1UdL29-0001PD-E7
	for emacs-orgmode@gnu.org; Fri, 17 May 2013 09:49:22 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1UdL28-00069K-4q
	for emacs-orgmode@gnu.org; Fri, 17 May 2013 09:49:21 -0400
Received: from mail-we0-x232.google.com ([2a00:1450:400c:c03::232]:54690)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <bastienguerry@gmail.com>) id 1UdL27-00069D-VP
	for emacs-orgmode@gnu.org; Fri, 17 May 2013 09:49:20 -0400
Received: by mail-we0-f178.google.com with SMTP id q57so3822636wes.9
	for <emacs-orgmode@gnu.org>; Fri, 17 May 2013 06:49:19 -0700 (PDT)
In-Reply-To: <87li7d99db.wl%max@openchat.com> (Max Mikhanosha's message of
	"Fri, 17 May 2013 06:41:20 -0400")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Max Mikhanosha <max@openchat.com>
Cc: "Rainer M. Krug" <Rainer@krugs.de>, emacs-orgmode@gnu.org

Hi Max,

Max Mikhanosha <max@openchat.com> writes:

> My list is.
>
> 1. Convert defvar to defcustom
>
> 2. Is (require 'dired) fine? It uses macro `dired-mark-if' defined in
>    dired.el

Seems fine to me.

> 3. The prefix C-c M-s seems awkward but Org is so big everything else
>    is taken, and C-c C-x s is too close to C-c C-x C-s, which is
>    archive subtree (I initially had it there and moved after archiving
>    subtree by mistake)

I'd favor reserving C-c C-x for core packages, and use anything else
for contrib/ packages.

> Its its fine to go in as is, then its fine too, I'm pretty lazy :-)

Whatever sounds more practical to you!  You can include it now,
have more eyes watching (after) your code, then feel the pressure
to overcome the laziness in implementing the above :) 

-- 
 Bastien