From mboxrd@z Thu Jan 1 00:00:00 1970 From: Feng Shu Subject: Re: [patch] [2update] Add functions, which can quickly insert org-contacts template(s) in current buffer Date: Tue, 04 Jun 2013 19:17:52 +0800 Message-ID: <87ip1u3z1b.fsf@news.tumashu-localhost.org> References: <87vc5vm96n.fsf@news.tumashu-localhost.org> <87r4gifbe1.fsf@bzg.ath.cx> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:45445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjpGm-0000zZ-7p for emacs-orgmode@gnu.org; Tue, 04 Jun 2013 07:19:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjpGj-0006Um-OR for emacs-orgmode@gnu.org; Tue, 04 Jun 2013 07:19:16 -0400 In-Reply-To: <87r4gifbe1.fsf@bzg.ath.cx> (Bastien's message of "Tue, 04 Jun 2013 11:55:34 +0200") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Bastien Cc: orgmode Bastien writes: > Hi Feng, > > Feng Shu writes: > >> * contrib/lisp/org-contacts.el >> (org-contacts-build-template-with-exist-contact):Build >> a contact template with exist contact, It is useful when you want to >> update exist contact(s). >> (org-contacts-build-template-with-string): Build contact template with >> a string, It is useful when you want to add a new contact. >> (org-contacts-insert-template): Insert contact template(s) at point, >> the template(s) will be built with the input string and exist contacts >> informations. > > Here is a reformatted ChangeLog for your patch: > > * contrib/lisp/org-contacts.el > (org-contacts-build-template-with-exist-contact) > (org-contacts-build-template-with-string): New methods for > building a contact template. > (org-contacts-insert-template): Insert a contact template at > point. The template will be built with the input string and > existing contact informations. > > The point is: try to be a bit more terse in your explanations, > and to pay attention to the punctuation. > > Sorry to nitpick about this -- even if the change is for contrib/, > it's good to know about the rules early on, and to lower the work > of maintainers because all the change logs need to be reviewed > at some point. Thanks for you information, I think this patch use a complex way to solve a simple problem, so I have writen a different patch to replace this patch! But the problem is that the new macro in the new patch can't work with org-capture and I can't figure out why .... I am afraid to write commit message, for I don't know many words. I have to write the commit message in chinese and google translate it ...... So you can see many Chinese style English in my commit. :-( > > Thanks for your efforts and your work on org-contacts.el! --