emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@gnu.org>
To: Oleh <ohwoeowho@gmail.com>
Cc: org mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] Add ob-J.el
Date: Fri, 20 Dec 2013 17:13:30 +0100	[thread overview]
Message-ID: <87ioujxzyt.fsf@bzg.ath.cx> (raw)
In-Reply-To: <CAA01p3qMfkO9uH-4pmszDUmO6SD7K=Kdxw7Vf3KDtby4=bSKRg@mail.gmail.com> (Oleh's message of "Fri, 20 Dec 2013 14:51:30 +0100")

Hi Oleh,

Oleh <ohwoeowho@gmail.com> writes:

> Here's a patch to add babel support for J.

Thanks.  Are you a FSF-signed contributor?  We cannot include
this in Org's core without your copyright assignment, let me know.

> I couldn't figure out how to make ob-J.elc a target for make,
> maybe someone can fix this.

No need to create a specific target.

Some comments on the code below:

> From 0139af8534dc33911ed1a24a9702a156ae46c99d Mon Sep 17 00:00:00 2001
> From: Oleh Krehel <ohwoeowho@gmail.com>
> Date: Fri, 20 Dec 2013 14:43:59 +0100
> Subject: [PATCH] Add org-babel support for J.
>
> ---
>  lisp/ob-J.el | 134 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 134 insertions(+)
>  create mode 100644 lisp/ob-J.el
>
> diff --git a/lisp/ob-J.el b/lisp/ob-J.el
> new file mode 100644
> index 0000000..50c1a5a
> --- /dev/null
> +++ b/lisp/ob-J.el
> @@ -0,0 +1,134 @@
> +;;; ob-J.el --- org-babel functions for J evaluation
> +
> +;; Copyright (C) 2011-2013 Free Software Foundation, Inc.
> +
> +;; Author: Oleh Krehel
> +;; Keywords: literate programming, reproducible research
> +;; Homepage: http://orgmode.org
> +
> +;; This file is part of GNU Emacs.

That's for Org's core (the lisp/ directory) but we can add
ob-J.el in contrib/lisp/ without the copyright assignment.

> +  (mapconcat #'identity (split-string body "\n") "\necho''\n"))
                ^

(mapconcat 'identity ...)

is fine.

> +(defun org-babel-J-strip-whitespace (str)
> +(defun obj-strip-leading-ws (s)

Maybe you can use org-trim here.

> +;;; ob-J.el ends here

Thanks for this contribution!

-- 
 Bastien

next prev parent reply	other threads:[~2013-12-20 16:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-20 13:51 [PATCH] Add ob-J.el Oleh
2013-12-20 16:13 ` Bastien [this message]
2013-12-20 17:12 ` Eric Schulte
2013-12-21  9:05   ` Oleh
2013-12-21 16:14   ` [BUG] " Rick Frankel
2013-12-21 17:40     ` Oleh
2013-12-21 18:58       ` Eric Schulte
2013-12-20 17:22 ` [PATCH] " Thomas S. Dye
2013-12-21  8:07   ` Oleh
2013-12-24 11:37   ` Oleh
2013-12-24 17:10     ` Thomas S. Dye

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ioujxzyt.fsf@bzg.ath.cx \
    --to=bzg@gnu.org \
    --cc=emacs-orgmode@gnu.org \
    --cc=ohwoeowho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).