From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bastien Subject: Re: [PATCH] Fixed bug in org-entry-get-with-inheritance Date: Mon, 17 Mar 2014 21:56:22 +0100 Message-ID: <87iorcpmrt.fsf@bzg.ath.cx> References: <87bnx9qbcq.fsf@bzg.ath.cx> <87vbvcptqt.fsf@Rainer.invalid> <87ob14d4o7.fsf@bzg.ath.cx> <87r460pr8d.fsf@Rainer.invalid> <87ha6wd3hg.fsf@bzg.ath.cx> <87mwgoppvf.fsf@Rainer.invalid> <87mwgopnrf.fsf@bzg.ath.cx> <87iorcpn0n.fsf@Rainer.invalid> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:36424) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPeaY-0004rC-9x for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 16:56:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WPeaT-0001Cz-5A for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 16:56:50 -0400 Received: from rs249.mailgun.us ([209.61.151.249]:38663) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WPeaS-0001Ch-Tx for emacs-orgmode@gnu.org; Mon, 17 Mar 2014 16:56:45 -0400 In-Reply-To: <87iorcpn0n.fsf@Rainer.invalid> (Achim Gratz's message of "Mon, 17 Mar 2014 21:51:04 +0100") List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Achim Gratz Cc: emacs-orgmode@gnu.org Achim Gratz writes: > Bastien writes: >> What I meant is this: broken tests are not a sufficient reason to >> revert a commit. You need to show the commit is wrong and the tests >> are not outdated. > > No code breaking a test should have been committed in the first place, > then we wouldn't need to have this discussion. If the "tests are > outdated" (in this case they ensure that the documentation and > implementation are matching up which is difficult to ascertain by just > playing with a single example, so that shouldn't ever happen), the onus > is on the committer to explain why and change the tests and > documentation accordingly (either as a preparation for that commit or in > the same commit). My assumption is that every committer does its best and that we collectively try to help each other. That's another way not to have this discussion. I'm fine fixing bugs and tests introduced by someone else. After all, I've answered hundreds of emails by people who are confused by the new way of setting Org's version (which I will revisit soon.) -- Bastien