From mboxrd@z Thu Jan  1 00:00:00 1970
From: Aaron Ecay <aaronecay@gmail.com>
Subject: Re: [RFC] [PATCH] ox-latex: support :float no with caption	for
 minted listings
Date: Mon, 22 Sep 2014 23:09:47 -0400
Message-ID: <87iokfoww4.fsf@gmail.com>
References: <1408779394-11436-1-git-send-email-aaronecay@gmail.com>
	<87ha13dm3v.fsf@nicolasgoaziou.fr> <87oavbostg.fsf@gmail.com>
	<87a96uep52.fsf@nicolasgoaziou.fr> <87d2bqpvgr.fsf@gmail.com>
	<87tx514qaa.fsf@nicolasgoaziou.fr> <87r401tdc7.fsf@gmail.com>
	<87oav5eztu.fsf@nicolasgoaziou.fr> <87mw9vqvo1.fsf@gmail.com>
	<877g0zv060.fsf_-_@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46652)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1XWGUO-0004Xt-SR
	for emacs-orgmode@gnu.org; Mon, 22 Sep 2014 23:10:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1XWGUF-0000Dq-Lt
	for emacs-orgmode@gnu.org; Mon, 22 Sep 2014 23:10:04 -0400
Received: from mail-qa0-x229.google.com ([2607:f8b0:400d:c00::229]:37472)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aaronecay@gmail.com>) id 1XWGUF-0000Df-Gx
	for emacs-orgmode@gnu.org; Mon, 22 Sep 2014 23:09:55 -0400
Received: by mail-qa0-f41.google.com with SMTP id cm18so1110835qab.14
	for <emacs-orgmode@gnu.org>; Mon, 22 Sep 2014 20:09:49 -0700 (PDT)
In-Reply-To: <877g0zv060.fsf_-_@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>, emacs-orgmode@gnu.org

Hi Nicolas,

2014ko irailak 19an, Nicolas Goaziou-ek idatzi zuen:

[...]

>=20
> In any case, I think you can apply the patch once the docstrings
> questions above have been sorted out.

Thanks for all your feedback.  The patch is now applied on master.

> This can do for now. Ultimately, however, I think we could merge
> `org-latex--wrap-label' into `org-latex--caption/label-string' (which
> should then produce "\captionof" command when appropriate). By then, the
> `replace-regexp-in-string' would not be needed anymore. WDYT?

I=E2=80=99m confused about how =E2=80=98org-latex--wrap-label=E2=80=99 work=
s.  It tries to
put \label commands outside of floats.  That will yield links that
jump to the preceding section, not the specific point in the document
where the \label command occurs.  Probably this command should insert
\phantomsection before the \label, so that resultant links jump to
the right point.  (I=E2=80=99ll make this change if no one objects.)

Merging the functions might only be worth doing if there were any more
places where \captionof needed to be used.  As long as it=E2=80=99s just a
particular kind of source block that needs it, I think this can stay as
a little special case in the source block transcoder.  The docstrings
seem to spell out the criteria for using one function vs. the other
well, so there=E2=80=99s little danger of confusion.  Adding \phantomsectio=
n to
=E2=80=98org-latex--wrap-label=E2=80=99 would also make them diverge furthe=
r in their
internal workings.

Thanks,

--=20
Aaron Ecay