From: Karl Fogel <kfogel@red-bean.com>
To: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Improve success message from org-remove-file.
Date: Tue, 25 Nov 2014 10:12:06 -0600 [thread overview]
Message-ID: <87ioi3p8dl.fsf@ktab.red-bean.com> (raw)
In-Reply-To: <873897ptz7.fsf@selenimh.mobile.lan> (Nicolas Goaziou's message of "Tue, 25 Nov 2014 09:25:32 +0100")
Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:
>Karl Fogel <kfogel@red-bean.com> writes:
>
>> The attached patch improves the interactive success message from
>> `org-remove-file'. Comments / suggestions welcome, of course; I've
>> tried to follow http://orgmode.org/worg/org-contribute.html here.
>
>Applied, thank you.
>
>I added "TINYCHANGE" at the end of your commit message.
Thanks for applying the change.
I didn't include "TINYCHANGE" on purpose. The guidelines say:
| If the change is a minor change made by a committer without
| copyright assignment to the FSF, the commit message should also
| contain the cookie TINYCHANGE (anywhere in the message). When we
| later produce the ChangeLog file for Emacs, the change will be
| marked appropriately.
However, I *do* have copyright assignment on file with the FSF (for
Emacs), so I interpreted the above as meaning I shouldn't include
"TINYCHANGE". What is the right thing to do here?
Best,
-Karl
next prev parent reply other threads:[~2014-11-25 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 17:36 [PATCH] Improve success message from org-remove-file Karl Fogel
2014-11-25 8:25 ` Nicolas Goaziou
2014-11-25 16:12 ` Karl Fogel [this message]
2014-11-25 19:51 ` Achim Gratz
2014-11-25 19:57 ` Achim Gratz
2014-11-26 11:35 ` Nicolas Goaziou
2014-12-01 13:44 ` Bastien
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ioi3p8dl.fsf@ktab.red-bean.com \
--to=kfogel@red-bean.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).