From mboxrd@z Thu Jan 1 00:00:00 1970 From: Achim Gratz Subject: Re: [RFC/PATCH] Fixes for org-timer Date: Sat, 13 Dec 2014 17:15:38 +0100 Message-ID: <87iohfmsph.fsf@Gertrud.fritz.box> References: <874mtdjmiv.fsf@kmlap.domain.org> <871togk60l.fsf@nicolasgoaziou.fr> <87sigwa7ip.fsf@kyleam.com> <87k328ifaz.fsf@nicolasgoaziou.fr> <87a92zvq07.fsf@kmlap.domain.org> <87oardchah.fsf@nicolasgoaziou.fr> <87r3w3napw.fsf@Gertrud.fritz.box> <87k31v8rky.fsf@nicolasgoaziou.fr> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:60307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzpMM-0001yt-6c for emacs-orgmode@gnu.org; Sat, 13 Dec 2014 11:16:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XzpMF-0005uG-Nb for emacs-orgmode@gnu.org; Sat, 13 Dec 2014 11:15:58 -0500 Received: from plane.gmane.org ([80.91.229.3]:42717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XzpMF-0005u8-G9 for emacs-orgmode@gnu.org; Sat, 13 Dec 2014 11:15:51 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XzpMD-0004qC-IA for emacs-orgmode@gnu.org; Sat, 13 Dec 2014 17:15:49 +0100 Received: from p4ff1cd1f.dip0.t-ipconnect.de ([79.241.205.31]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 13 Dec 2014 17:15:49 +0100 Received: from Stromeko by p4ff1cd1f.dip0.t-ipconnect.de with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 13 Dec 2014 17:15:49 +0100 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: emacs-orgmode@gnu.org Nicolas Goaziou writes: >> The new tests don't work on Emacs23, mainly due to the use of cl-letf. > > I fixed the `cl-letf' issue, thank you. Is there anything else to do? Not with respect to this change, the tests are now all passing. However, Emacs master seems to have changed the signature for call-process-shell-command, so Org might need to work around this with a new compatibility macro. In toplevel form: org-clock.el:1094:13:Warning: call-process-shell-command called with 6 arguments, but accepts only 1-4 Regards, Achim. -- +<[Q+ Matrix-12 WAVE#46+305 Neuron microQkb Andromeda XTk Blofeld]>+ Wavetables for the Terratec KOMPLEXER: http://Synth.Stromeko.net/Downloads.html#KomplexerWaves