emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
* [PATCH] contrib: rip out org-jira
@ 2015-07-18  1:00 Mitchel Humpherys
  2015-07-20 21:09 ` Nicolas Goaziou
  0 siblings, 1 reply; 3+ messages in thread
From: Mitchel Humpherys @ 2015-07-18  1:00 UTC (permalink / raw)
  To: emacs-orgmode; +Cc: Mitchel Humpherys

Its changelog says it's abandoned, it doesn't really do anything, and it
clashes with [1].  Rip it out.

[1] https://github.com/baohaojun/org-jira
---
 contrib/README           |  1 -
 contrib/lisp/org-jira.el | 64 ------------------------------------------------
 lisp/org.el              |  1 -
 3 files changed, 66 deletions(-)
 delete mode 100644 contrib/lisp/org-jira.el

diff --git a/contrib/README b/contrib/README
index 7204cc312df4..6a8918fefb15 100644
--- a/contrib/README
+++ b/contrib/README
@@ -37,7 +37,6 @@ org-git-link.el          --- Provide org links to specific file version
 org-index.el             --- A personal index for org and beyond
 org-interactive-query.el --- Interactive modification of tags query
 org-invoice.el           --- Help manage client invoices in OrgMode
-org-jira.el              --- Add a jira:ticket protocol to Org
 org-learn.el             --- SuperMemo's incremental learning algorithm
 org-license.el		 --- Insert free licenses to your org documents
 org-mac-iCal.el          --- Imports events from iCal.app to the Emacs diary
diff --git a/contrib/lisp/org-jira.el b/contrib/lisp/org-jira.el
deleted file mode 100644
index 43edd08817d9..000000000000
--- a/contrib/lisp/org-jira.el
+++ /dev/null
@@ -1,64 +0,0 @@
-;;; org-jira.el --- add a jira:ticket protocol to Org
-(defconst org-jira-version "0.1")
-;; Copyright (C) 2008-2014 Jonathan Arkell.
-;; Author: Jonathan Arkell <jonnay@jonnay.net>
-
-;; This file is not part of GNU Emacs.
-
-;; This program is free software; you can redistribute it and/or
-;; modify it under the terms of the GNU General Public License as
-;; published by the Free Software Foundation version 2.
-
-;; This program is distributed in the hope that it will be useful, but
-;; WITHOUT ANY WARRANTY; without even the implied warranty of
-;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
-;; General Public License for more details.
-
-;; You should have received a copy of the GNU General Public License
-;; along with GNU Emacs.  If not, see <http://www.gnu.org/licenses/>.
-
-;;; Commentary:
-;; This adds a jira protocol to org mode.
-
-;;; Commands:
-;;
-;; Below are complete command list:
-;;
-;;
-;;; Customizable Options:
-;;
-;; Below are customizable option list:
-;;
-
-;; I had initially planned on adding bi-directional linking, so you
-;; could store links from a jira ticket.  I also wanted to import
-;; tickets assigned to you as a task.  However, I am no longer working
-;; with JIRA, so this is now abandonware.
-
-;;; Installation:
-;; Put org-jira.el somewhere in your load-path.
-;; (Use M-x show-variable RET load-path to see what your load path is.)
-;; Add this to your emacs init file, preferably after you load org mode.
-;(require 'org-jira)
-
-;;; TODO:
-;; - bi-directional links
-;; - deeper importing, like tasks...?
-
-;;; CHANGELOG:
-;; v 0.2 - ran through checkdoc
-;;       - Abandoned.
-;; v 0.1 - Initial release
-
-(require 'jira)
-
-(org-add-link-type "jira" 'org-jira-open)
-
-(defun org-jira-open (path)
-  "Open a Jira Link from PATH."
-  (jira-show-issue path))
-
-
-(provide 'org-jira)
-
-;;; org-jira.el ends here
diff --git a/lisp/org.el b/lisp/org.el
index 6a51ede12632..0aa923ce3269 100755
--- a/lisp/org.el
+++ b/lisp/org.el
@@ -724,7 +724,6 @@ For export specific modules, see also `org-export-backends'."
 	(const :tag "C  git-link:          Provide org links to specific file version" org-git-link)
 	(const :tag "C  interactive-query: Interactive modification of tags query\n\t\t\t(PARTIALLY OBSOLETE, see secondary filtering)" org-interactive-query)
         (const :tag "C  invoice:           Help manage client invoices in Org-mode" org-invoice)
-	(const :tag "C  jira:              Add a jira:ticket protocol to Org-mode" org-jira)
 	(const :tag "C  learn:             SuperMemo's incremental learning algorithm" org-learn)
 	(const :tag "C  mac-iCal           Imports events from iCal.app to the Emacs diary" org-mac-iCal)
 	(const :tag "C  mac-link:          Grab links and url from various mac Applications" org-mac-link)
-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] contrib: rip out org-jira
  2015-07-18  1:00 [PATCH] contrib: rip out org-jira Mitchel Humpherys
@ 2015-07-20 21:09 ` Nicolas Goaziou
  2015-08-05  0:01   ` Bastien Guerry
  0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Goaziou @ 2015-07-20 21:09 UTC (permalink / raw)
  To: Mitchel Humpherys; +Cc: emacs-orgmode

Hello,

Mitchel Humpherys <mitch.special@gmail.com> writes:

> Its changelog says it's abandoned, it doesn't really do anything, and it
> clashes with [1].  Rip it out.

Thank you.

Could you provide patch with a proper commit message, using
format-patch?


Regards,

-- 
Nicolas Goaziou

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] contrib: rip out org-jira
  2015-07-20 21:09 ` Nicolas Goaziou
@ 2015-08-05  0:01   ` Bastien Guerry
  0 siblings, 0 replies; 3+ messages in thread
From: Bastien Guerry @ 2015-08-05  0:01 UTC (permalink / raw)
  To: Nicolas Goaziou; +Cc: Mitchel Humpherys, emacs-orgmode

Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Could you provide patch with a proper commit message, using
> format-patch?

I pushed this patch.  Mitchel, thanks for adding a changelog
for your next patch.

-- 
 Bastien

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-08-05  0:27 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-18  1:00 [PATCH] contrib: rip out org-jira Mitchel Humpherys
2015-07-20 21:09 ` Nicolas Goaziou
2015-08-05  0:01   ` Bastien Guerry

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).