From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jan Malakhovski Subject: Re: [PATCH 6/9] factor out date-timestamp* calculations to org-store-link-props Date: Wed, 04 Nov 2015 11:45:44 +0000 Message-ID: <87io5im1hz.fsf@yin.lan> References: <1446581747-1960-1-git-send-email-oxij@oxij.org> <1446581747-1960-7-git-send-email-oxij@oxij.org> <87io5ivwci.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:4830:134:3::10]:39163) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtwVs-0000ia-KB for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:46:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZtwVn-0007w2-Ku for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:46:00 -0500 Received: from fujibayashi-1-pt.tunnel.tserv10.par1.ipv6.he.net ([2001:470:1f12:446::2]:30020 helo=tricoro.koumakan.jp) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZtwVn-0007vy-FB for emacs-orgmode@gnu.org; Wed, 04 Nov 2015 06:45:55 -0500 In-Reply-To: <87io5ivwci.fsf@gmail.com> List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org To: Aaron Ecay , emacs-orgmode@gnu.org Aaron Ecay writes: > Can you introduce a let binding so that (date-to-time x) is only called > once? Ok. > Also, what is ignore-errors protecting? The call to date-to-time, or > format-time-string? I think the scope of ignore-errors should be as > narrow as it can be. I have no idea. I moved these lines from org-gnus, equivalent lines in org-*other-mail-reader*s don't use ignore-errors at all. I don't use gnus so went for the safest change.