From mboxrd@z Thu Jan  1 00:00:00 1970
From: Sebastian =?utf-8?Q?Reu=C3=9Fe?= <seb@wirrsal.net>
Subject: Re: [PATCH 1/2] Add tests for org-refile-get-targets
Date: Mon, 22 May 2017 08:46:07 +0200
Message-ID: <87inktmlsg.fsf@wirrsal.net>
References: <20170515125455.18251-1-seb@wirrsal.net>
	<87efvqxeha.fsf@nicolasgoaziou.fr> <87d1b7gw7r.fsf@wirrsal.net>
	<87pof1hgjb.fsf@nicolasgoaziou.fr>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40894)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <seb@wirrsal.net>) id 1dCh6e-0003ct-T4
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 02:46:17 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <seb@wirrsal.net>) id 1dCh6a-0000Rc-1p
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 02:46:16 -0400
Received: from wirrsal.net ([188.68.36.149]:55358 helo=mail.wirrsal.net)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <seb@wirrsal.net>) id 1dCh6Z-0000RB-OH
	for emacs-orgmode@gnu.org; Mon, 22 May 2017 02:46:12 -0400
In-reply-to: <87pof1hgjb.fsf@nicolasgoaziou.fr>
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Cc: emacs-orgmode@gnu.org


Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Sebastian Reu=C3=9Fe <seb@wirrsal.net> writes:

>> It didn=E2=80=99t feel right copy-pasting the tests wholesale, so I ma=
de a
>> helper-macro. I checked the ert output by forcing a failure and the
>> failure explanation looks as expected. Does this work for you?

> Honestly, I still find it difficult to follow and debug when one the
> tests is failing. Also, we can't use `alist-get' since we are still
> supporting Emacs 24.3.

Fair enough. Thank you! FWIW, is there some handy table to consult on
newly supported functions by Emacs version? Or do you have it all
memorized from the Emacs changelogs?

Kind regards,

--=20
Insane cobra split the wood
Trader of the lowland breed
Call a jittney, drive away
In the slipstream we will stay