From: Kyle Meyer <kyle@kyleam.com>
To: Kaushal Modi <kaushal.modi@gmail.com>,
emacs-org list <emacs-orgmode@gnu.org>
Subject: Re: Fix org.el compilation warnings
Date: Thu, 25 May 2017 22:53:52 -0400 [thread overview]
Message-ID: <87inkouy4f.fsf@kyleam.com> (raw)
In-Reply-To: <CAFyQvY2a7+0Tf=2WtBpaYtw_JYO=foLOKU+bumaVLofwuFzyzg@mail.gmail.com>
Kaushal Modi <kaushal.modi@gmail.com> writes:
> On Thu, May 25, 2017, 7:59 PM Kyle Meyer <kyle@kyleam.com> wrote:
>
>> Kaushal Modi <kaushal.modi@gmail.com> writes:
>>
>> > I was trying to fix the org.el compilation warnings.
>>
>> I don't see any compiler warnings when I run 'make compile' with either
>> master (2960dc971) or maint (89bd7ad87) on Emacs 25.2.
>>
>
> Those warnings were on master using the latest build of emacs from master.
>
> I was compiling just org.el, may be that's why?
Ah, right ... 'make compile' uses a single Emacs instance, while 'make
single' uses a separate Emacs instance for each file.
With 'make single' on master, I get a compile error due to the
eval-when-compile's added in 53ee147f4 (Add support for new switches to
org-get-heading, 2017-01-17) and 6dc6eb3b0 (Fix failing test,
2017-01-19).
In toplevel form:
org.el:7914:51:Error: Symbol’s value as variable is void: org-comment-string
If I wrap (defconst org-comment-string ...) in eval-and-compile to get
rid of those, I see your reported warning and a few others (but not the
others that you reported):
In org-at-timestamp-p:
org.el:17946:40:Warning: reference to free variable
‘org-agenda-include-inactive-timestamps’
In org--get-expected-indentation:
org.el:22608:28:Warning: reference to free variable
‘org-element-greater-elements’
In end of data:
org.el:24980:1:Warning: the following functions are not known to be defined:
org-table-sort-lines, org-duration-from-minutes
I think all of these should be addressed.
> But even then, shouldn't the free variable warning, that I fix in the patch
> I just provided, be fixed?
Your patch is only the appropriate fix if we're confident that
org-agenda will be loaded at the time that the
org-agenda-include-inactive-timestamps code path of org-at-timestamp-p
is executed. Otherwise, we're just silencing a warning about a possible
run-time void variable error. Have you looked this?
--
Kyle
next prev parent reply other threads:[~2017-05-26 2:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-25 22:31 Fix org.el compilation warnings Kaushal Modi
2017-05-25 23:59 ` Kyle Meyer
2017-05-26 0:35 ` Kaushal Modi
2017-05-26 2:53 ` Kyle Meyer [this message]
2017-05-26 4:32 ` [PATCH] Silence byte-compiler under "make single" Kyle Meyer
2017-05-26 18:14 ` Fix org.el compilation warnings Kaushal Modi
2017-05-26 20:45 ` Kyle Meyer
2017-05-26 22:31 ` Kaushal Modi
2017-05-26 23:17 ` syncing with Emacs (was: Fix org.el compilation warnings) Kyle Meyer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inkouy4f.fsf@kyleam.com \
--to=kyle@kyleam.com \
--cc=emacs-orgmode@gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).