From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: [PATCH] Refactor org-set-tags arguments for clarity
Date: Thu, 13 Jul 2017 14:31:59 +0200
Message-ID: <87iniwfrgg.fsf@nicolasgoaziou.fr>
References: <CAFyQvY1aDNQgnwwtWaC00Z__okrDT_Y0RLbPko-_=tNc+pNZjA@mail.gmail.com>
	<87pod4zs9i.fsf@nicolasgoaziou.fr>
	<CAFyQvY1ECiNyyRTUi-AQH-8H8-Xu=sU_S-fW2iurgVWwm-fB0w@mail.gmail.com>
	<87r2xkft0t.fsf@nicolasgoaziou.fr>
	<CAFyQvY3k44hSgzomABKsd4Up7iy4FoJQvMXDWWMR1YcALpebng@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39429)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dVdHu-0001tq-Hv
	for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 08:32:11 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1dVdHq-00089k-Gr
	for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 08:32:10 -0400
Received: from relay2-d.mail.gandi.net ([217.70.183.194]:37381)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1dVdHq-00087r-9U
	for emacs-orgmode@gnu.org; Thu, 13 Jul 2017 08:32:06 -0400
In-Reply-To: <CAFyQvY3k44hSgzomABKsd4Up7iy4FoJQvMXDWWMR1YcALpebng@mail.gmail.com>
	(Kaushal Modi's message of "Thu, 13 Jul 2017 12:21:32 +0000")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Kaushal Modi <kaushal.modi@gmail.com>
Cc: emacs-org list <emacs-orgmode@gnu.org>

Kaushal Modi <kaushal.modi@gmail.com> writes:

> Correct. I was just extrapolating based on that, that people could be
> making similar uses in their configs and packages.
>
> A search like this (
> https://github.com/search?utf8=%E2%9C%93&q=%22org-set-tags+nil%22+language%3A%22Emacs+Lisp%22&type=Code
> )
> shows that (org-set-tags nil t) is pretty viral in one org-settings.el out
> there.

Then what about something like this

  (defun org-set-tags (&optional align-all align-current)
    "...
  ...
  ALIGN-CURRENT is obsolete and should not be used. When non-nil,
  set ALIGN-ALL to `current'."
    (let ((align-all (if (null align-current) align-all
                       (warn "Deprecated call to `org-set-tags', which see")
                       'current)))
     ...))


Regards,