From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Alex Branham <alex.branham@gmail.com>
Cc: Org-mode <emacs-orgmode@gnu.org>
Subject: Re: [PATCH] make org-comment-dwim comment headings if on a heading
Date: Wed, 29 Nov 2017 14:46:55 +0100 [thread overview]
Message-ID: <87indtp580.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <87po84to5n.fsf@gmail.com> (Alex Branham's message of "Sun, 26 Nov 2017 21:07:32 -0600")
Hello,
Alex Branham <alex.branham@gmail.com> writes:
> I've attached the updated patch (with a test), but the test fails
> because calling M-x comment-dwim in an org buffer on a heading results
> in the old behavior of comment-dwim rather than the new behavior.
> Calling M-x org-comment-dwim directly works as I expect (and M-; works
> like this too). Do you have any idea what might be going on? I thought
> they would behave the same since comment-dwim is mapped to
> org-comment-dwim, but that doesn't seem to be the case...
Mapping means `org-comment-dwim' binding replaces `comment-dwim'
binding, which doesn't mean both functions are mapped to each other.
The tests in "test-org.el" were broken: they tested `comment-dwim'
instead of `org-comment-dwim'. I fixed the tests, then applied your
patch.
I also added TINYCHANGE at the end of the commit message. Please
consider signing FSF papers if you haven't done so. If you did, let me
know it so I can update our registry.
Would you mind writing an entry in ORG-NEWS? It could go in
"Miscellaneous" section.
Thank you!
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2017-11-29 13:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 21:14 [PATCH] make org-comment-dwim comment headings if on a heading Alex Branham
2017-11-22 23:17 ` Nicolas Goaziou
2017-11-27 3:07 ` Alex Branham
2017-11-29 13:46 ` Nicolas Goaziou [this message]
2017-11-29 15:24 ` Alex Branham
2017-11-29 20:17 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87indtp580.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=alex.branham@gmail.com \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).