From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
Subject: Re: Bug: missing `save-excursion' in `org-fast-tag-selection' [9.2.3
 (9.2.3-9-g0803e2-elpa @ /home/il/.emacs.d/elpa/org-20190422/)]
Date: Mon, 29 Apr 2019 19:21:51 +0200
Message-ID: <87imuwn2vk.fsf@nicolasgoaziou.fr>
References: <87k1ff20bn.fsf@kenko.localhost.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
Received: from eggs.gnu.org ([209.51.188.92]:39620)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1hL9yY-0005VE-CW
	for emacs-orgmode@gnu.org; Mon, 29 Apr 2019 13:21:59 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mail@nicolasgoaziou.fr>) id 1hL9yX-0001s4-K6
	for emacs-orgmode@gnu.org; Mon, 29 Apr 2019 13:21:58 -0400
Received: from relay11.mail.gandi.net ([217.70.178.231]:57331)
	by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)
	(Exim 4.71) (envelope-from <mail@nicolasgoaziou.fr>)
	id 1hL9yX-0001qx-C5
	for emacs-orgmode@gnu.org; Mon, 29 Apr 2019 13:21:57 -0400
In-Reply-To: <87k1ff20bn.fsf@kenko.localhost.com> (Ingo Lohmar's message of
	"Sat, 27 Apr 2019 12:45:48 +0200")
List-Id: "General discussions about Org-mode." <emacs-orgmode.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/emacs-orgmode/>
List-Post: <mailto:emacs-orgmode@gnu.org>
List-Help: <mailto:emacs-orgmode-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/emacs-orgmode>,
	<mailto:emacs-orgmode-request@gnu.org?subject=subscribe>
Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org
Sender: "Emacs-orgmode"
	<emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org>
To: Ingo Lohmar <ingo.lohmar@posteo.net>
Cc: emacs-orgmode@gnu.org

Hello,

Ingo Lohmar <ingo.lohmar@posteo.net> writes:


> I tried to use `org-agenda-set-tags'.  The source buffer (where the
> change should be applied) is visible at the same time as the agenda is.
> Also, fast tag selection with a single key is enabled.
>
> Under these circumstances, the tag text is appended to the line (not
> even necessarily a heading!) where point is in the source buffer visible
> next to the agenda, instead of the correct heading that I acted upon.
>
> I tracked this done to a missing `save-excursion' wrapped around the
> `save-window-excursion' in `org-fast-tag-selection' (org.el line 14567
> in my version).  This would be analogous to what is done in
> `org-fast-todo-selection' and fixes my issue.

Would you mind sending a patch?

Thank you.

Regards,

-- 
Nicolas Goaziou