From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Porter Subject: Re: [PATCH] org: org-get-priority: reduce `not`, deduplicate magic `(* 1000 ..)` operation Date: Wed, 09 Oct 2019 14:33:06 -0500 Message-ID: <87imoxr9xp.fsf@alphapapa.net> References: <10577751569717294@sas1-a0d9133b67ec.qloud-c.yandex.net> <87imozeggw.fsf@nicolasgoaziou.fr> <5203711570570088@iva5-58d151f416d2.qloud-c.yandex.net> <2458361570573406@sas8-93eeb7dac565.qloud-c.yandex.net> Mime-Version: 1.0 Content-Type: text/plain Return-path: Received: from eggs.gnu.org ([2001:470:142:3::10]:54876) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iIHi5-0000mZ-9j for emacs-orgmode@gnu.org; Wed, 09 Oct 2019 15:33:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iIHi4-0005P0-A6 for emacs-orgmode@gnu.org; Wed, 09 Oct 2019 15:33:21 -0400 Received: from 195-159-176-226.customer.powertech.no ([195.159.176.226]:42486 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iIHi4-0005OS-3C for emacs-orgmode@gnu.org; Wed, 09 Oct 2019 15:33:20 -0400 Received: from list by blaine.gmane.org with local (Exim 4.89) (envelope-from ) id 1iIHi0-000J4V-8H for emacs-orgmode@gnu.org; Wed, 09 Oct 2019 21:33:16 +0200 List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+geo-emacs-orgmode=m.gmane.org@gnu.org Sender: "Emacs-orgmode" To: emacs-orgmode@gnu.org Hi Anton, Nicolas, et al, I'm in favor of tidying up the priority-related code, as I also have found it hard to follow. But please do not change the API of these functions, i.e. the signatures and return values. Their output is used in other packages, including some of mine like org-rifle, org-super-agenda, and org-ql. If the API were to change, it would create significant headaches in writing compatibility code for different Org versions. I can't easily tell if that's something that's been proposed, but I'm making the request just in case. Thanks, Adam