emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed
From: Kyle Meyer <kyle@kyleam.com>
To: Jack Kamm <jackkamm@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix several issues with python session value blocks
Date: Thu, 23 Jan 2020 05:24:36 +0000	[thread overview]
Message-ID: <87iml2agob.fsf@kyleam.com> (raw)
In-Reply-To: <87pnfdo88v.fsf@gmail.com>

Jack Kamm <jackkamm@gmail.com> writes:

> This patch fixes several related issues with python blocks with
> parameters ":session :results value", including:
>
> - Broken if-else and try-except statements.
> - Correctly parsing blank lines in indented blocks.
> - Returning the correct value when the underscore "_" variable
>   has been assigned.
> [...]
> There is some useful background and discussion of the issues here:
>
> https://lists.gnu.org/archive/html/emacs-orgmode/2017-11/msg00274.html
>
> In that thread from 2017, we solved similar problems for the ":results
> output" case. With this patch, I'm now circling back to try and fix the
> ":results value" case.

Thanks!  I'll plan to take a deeper look within the next week.  However,
given that I'm not an ob-python user (or a much of a babel user in
general), I hope those who are will try out your patch and give
feedback.

  reply	other threads:[~2020-01-23  5:24 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-21  2:26 [PATCH] Fix several issues with python session value blocks Jack Kamm
2020-01-23  5:24 ` Kyle Meyer [this message]
2020-01-23  6:26   ` Jack Kamm
2020-01-30  5:50     ` Kyle Meyer
2020-02-04  2:27       ` Jack Kamm
2020-02-04  2:44         ` Kyle Meyer
2020-02-04  5:27           ` Jack Kamm
2020-02-04  8:40             ` Bastien
2020-02-04 14:56               ` Jack Kamm
2020-01-26 16:36 ` Bastien
2020-01-26 21:05   ` Jack Kamm
2020-01-27  8:19     ` Bastien
2020-01-27 11:18 ` 황병희

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iml2agob.fsf@kyleam.com \
    --to=kyle@kyleam.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=jackkamm@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).