emacs-orgmode@gnu.org archives
 help / color / mirror / code / Atom feed

From: Bastien <bzg@gnu.org>
To: Kyle Meyer <kyle@kyleam.com>
Cc: Dan Drake <dan.drake@gmail.com>, emacs-orgmode@gnu.org
Subject: Re: specify time of day for org-resolve-clocks, not number of minutes
Date: Thu, 13 Feb 2020 08:16:18 +0100	[thread overview]
Message-ID: <87imkbez3x.fsf@bzg.fr> (raw)
In-Reply-To: 877e0ri7sb.fsf@kyleam.com

Hi Kyle and Dan,

Kyle Meyer <kyle@kyleam.com> writes:

> Thanks, though sadly Dan had already taken the time to follow up with a
> patch:
>
>   https://lists.gnu.org/archive/html/emacs-orgmode/2020-01/msg00175.html

Err, my bad, sorry Dan -- and thanks Kyle for the warning.

(I too hastily assume 1 thread = 1 topic, I should have checked.)

I reverted my changes and pushed Dan's commit to master.

I took the liberty of inlining the function and making the message a
bit more explicit.  Dan, let me know if that's okay.

Interestingly, our (different and complementary) implementations may
lead to a new idea: your implementation is like the `k' option while
mine is like the `g' option (when you "got back").  I guess both can
make sense, and what the user expect is to be able to enter a number
of minutes *or* a HH:MM time spec in both `t' and `g'.

That would also have the advantage of having less options while still
having the possibility to use HH:MM.  (Also, using org-read-date here
seems a bit too much here, but maybe that's okay.)

Dan, what do you think?  Would you like to try implementing this or
can I give it a try?

Thanks,

-- 
 Bastien

next prev parent reply	other threads:[~2020-02-13  7:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-03 15:05 specify time of day for org-resolve-clocks, not number of minutes Dan Drake
2020-01-07  8:17 ` Nicolas Goaziou
2020-02-13  0:31 ` Bastien
2020-02-13  1:40   ` Kyle Meyer
2020-02-13  7:16     ` Bastien [this message]
2020-02-13 14:02       ` Dan Drake
2020-02-13 14:53         ` Bastien

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.orgmode.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imkbez3x.fsf@bzg.fr \
    --to=bzg@gnu.org \
    --cc=dan.drake@gmail.com \
    --cc=emacs-orgmode@gnu.org \
    --cc=kyle@kyleam.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).