From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id SAhhEqnQnV5NcgAA0tVLHw (envelope-from ) for ; Mon, 20 Apr 2020 16:41:13 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gJaXFa7QnV79LgAA1q6Kng (envelope-from ) for ; Mon, 20 Apr 2020 16:41:18 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9A40D941CD7 for ; Mon, 20 Apr 2020 16:41:17 +0000 (UTC) Received: from localhost ([::1]:39210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jQZTv-0001XK-Ri for larch@yhetil.org; Mon, 20 Apr 2020 12:41:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51832 helo=eggs1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jQZT9-0001VJ-AC for emacs-orgmode@gnu.org; Mon, 20 Apr 2020 12:40:27 -0400 Received: from Debian-exim by eggs1p.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jQZT8-0006uH-7J for emacs-orgmode@gnu.org; Mon, 20 Apr 2020 12:40:26 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:46237) by eggs1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jQZT7-0006pH-Ca for emacs-orgmode@gnu.org; Mon, 20 Apr 2020 12:40:25 -0400 X-Originating-IP: 185.131.40.67 Received: from localhost (40-67.ipv4.commingeshautdebit.fr [185.131.40.67]) (Authenticated sender: admin@nicolasgoaziou.fr) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 4C10BC000A; Mon, 20 Apr 2020 16:40:20 +0000 (UTC) From: Nicolas Goaziou To: Brian Powell Subject: Re: [PATCH] Re: Inconsistent use of \ref and \eqref in ox-latex and ox-html References: <87h7xhxlyt.fsf@nicolasgoaziou.fr> <87k12bwy6g.fsf@nicolasgoaziou.fr> Mail-Followup-To: Brian Powell , emacs-orgmode@gnu.org Date: Mon, 20 Apr 2020 18:40:20 +0200 In-Reply-To: (Brian Powell's message of "Sun, 19 Apr 2020 13:13:50 -1000") Message-ID: <87imhurtzf.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=217.70.183.198; envelope-from=mail@nicolasgoaziou.fr; helo=relay6-d.mail.gandi.net X-detected-operating-system: by eggs1p.gnu.org: First seen = 2020/04/20 12:40:22 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Received-From: 217.70.183.198 X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Scanner: scn0 X-Spam-Score: -1.11 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Scan-Result: default: False [-1.11 / 13.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; GENERIC_REPUTATION(0.00)[-0.5696568815829]; HAS_XOIP(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.51.188.0/24:c]; IP_REPUTATION_HAM(0.00)[asn: 22989(0.23), country: US(-0.01), ip: 209.51.188.17(-0.57)]; MX_GOOD(-0.50)[cached: eggs.gnu.org]; RCPT_COUNT_TWO(0.00)[2]; MAILLIST(-0.20)[mailman]; FORGED_RECIPIENTS_MAILLIST(0.00)[]; RCVD_IN_DNSWL_LOW(-0.10)[209.51.188.17:from]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:22989, ipnet:209.51.188.0/24, country:US]; MID_RHS_MATCH_FROM(0.00)[]; TAGGED_FROM(0.00)[larch=yhetil.org]; ARC_NA(0.00)[]; RCVD_COUNT_FIVE(0.00)[6]; FROM_NEQ_ENVFROM(0.00)[mail@nicolasgoaziou.fr,emacs-orgmode-bounces@gnu.org]; FROM_HAS_DN(0.00)[]; URIBL_BLOCKED(0.00)[hawaii.edu:email]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[nicolasgoaziou.fr]; HAS_LIST_UNSUB(-0.01)[]; FORGED_SENDER_MAILLIST(0.00)[] X-TUID: nuIUYlXhZ6I0 Hello, Brian Powell writes: > Nicolas, thank you for the feedback, and I apologize for my errors. No need to apologize! Peer review is about catching the mistakes we all do. > I have corrected the issues below and generated a commit patch attached. Please let me know if there are any problems. Thank you! I have some more work for you, if you don't mind ;) > Subject: [PATCH] add org-html-equation-reference-format to customize MathJax > ref command The commit message should reference the file being modified. I suggest something along the lines: Add customizable format string for equations * lisp/ox-html.el (org-html-equation-reference-format): New variable. > +(defcustom org-html-equation-reference-format "\\eqref{%s}" > + "MathJax command to use when referencing equations. This is a > +format controls string, expecting a single argument, the equation > +being referenced that is generated on export. Small nit here. The first line of a docstring must contain complete sentences only. Therefore you need to move "This is a" part to the line below. Also : controls -> control Otherwise, it looks good! Could you provide an entry in ORG-NEWS about it? I think Version 9.4 > Miscellaneous is a fine place for it. Regards, -- Nicolas Goaziou