From: Nicolas Goaziou <mail@nicolasgoaziou.fr>
To: Brian Powell <powellb@hawaii.edu>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Re: Inconsistent use of \ref and \eqref in ox-latex and ox-html
Date: Mon, 20 Apr 2020 18:40:20 +0200 [thread overview]
Message-ID: <87imhurtzf.fsf@nicolasgoaziou.fr> (raw)
In-Reply-To: <m28sir3w7l.fsf@hawaii.edu> (Brian Powell's message of "Sun, 19 Apr 2020 13:13:50 -1000")
Hello,
Brian Powell <powellb@hawaii.edu> writes:
> Nicolas, thank you for the feedback, and I apologize for my errors.
No need to apologize! Peer review is about catching the mistakes we all
do.
> I have corrected the issues below and generated a commit patch attached. Please let me know if there are any problems.
Thank you! I have some more work for you, if you don't mind ;)
> Subject: [PATCH] add org-html-equation-reference-format to customize MathJax
> ref command
The commit message should reference the file being modified. I suggest
something along the lines:
Add customizable format string for equations
* lisp/ox-html.el (org-html-equation-reference-format): New variable.
> +(defcustom org-html-equation-reference-format "\\eqref{%s}"
> + "MathJax command to use when referencing equations. This is a
> +format controls string, expecting a single argument, the equation
> +being referenced that is generated on export.
Small nit here. The first line of a docstring must contain complete
sentences only. Therefore you need to move "This is a" part to the line
below.
Also : controls -> control
Otherwise, it looks good! Could you provide an entry in ORG-NEWS about
it? I think Version 9.4 > Miscellaneous is a fine place for it.
Regards,
--
Nicolas Goaziou
next prev parent reply other threads:[~2020-04-20 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 21:56 Brian Powell
2020-04-18 8:00 ` Nicolas Goaziou
2020-04-19 7:22 ` Brian Powell
2020-04-19 10:46 ` Nicolas Goaziou
2020-04-19 23:13 ` [PATCH] " Brian Powell
2020-04-20 16:40 ` Nicolas Goaziou [this message]
2020-04-20 19:52 ` Brian Powell
2020-04-21 17:46 ` Nicolas Goaziou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.orgmode.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imhurtzf.fsf@nicolasgoaziou.fr \
--to=mail@nicolasgoaziou.fr \
--cc=emacs-orgmode@gnu.org \
--cc=powellb@hawaii.edu \
--subject='Re: [PATCH] Re: Inconsistent use of \ref and \eqref in ox-latex and ox-html' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Code repositories for project(s) associated with this inbox:
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).